Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation string of Rotational.Interfaces.Flange_a and Flange_b #2298

Closed
christiankral opened this issue Aug 16, 2017 · 1 comment
Closed

Fix documentation string of Rotational.Interfaces.Flange_a and Flange_b #2298

christiankral opened this issue Aug 16, 2017 · 1 comment
Assignees
@christiankral @MartinOtter
Labels
documentation Issue addresses the documentation L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational
Milestone
MSL3.2.3

Comments

@christiankral
Copy link
Contributor

The documentation string of Modelica.Mechanics.Rotational.Interfaces.Flange_a and Modelica.Mechanics.Rotational.Interfaces.Flange_b is partially wrong:

connector Flange_a
  "1-dim. rotational flange of a shaft (filled square icon)"

and

connector Flange_b
  "1-dim. rotational flange of a shaft (non-filled square icon)"

As the connector does not have a square icon I propose the following:

connector Flange_a
  "One-dimensional rotational flange of a shaft (filled circle icon)"

and

connector Flange_b
  "One-dimensional rotational flange of a shaft  (non-filled circle icon)"
@christiankral christiankral added bug Critical/severe issue L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational labels Aug 16, 2017
@christiankral christiankral added this to the MSL_next-MINOR-version milestone Aug 16, 2017
@christiankral christiankral changed the title Improve documentation string of Rotational.Interfaces.Flange_a and Flange_b Fix documentation string of Rotational.Interfaces.Flange_a and Flange_b Aug 16, 2017
christiankral added a commit that referenced this issue Aug 18, 2017
@christiankral
Fixed wrong documentation string of Rotational Flange_a and Flange_b,…
d89d411 
… see #2298
christiankral added a commit that referenced this issue Aug 18, 2017
@christiankral
Fixed wrong documentation string of Rotational Flange_a and Flange_b,…
dbcd26a 
… see #2298
@christiankral
Copy link
Contributor Author

Fixed

beutlich added a commit that referenced this issue Aug 21, 2017
@beutlich
refs #2298: Delete superfluous blank in comment string
8bc9010
@beutlich beutlich changed the title Fix documentation string of Rotational.Interfaces.Flange_a and Flange_b Fix documentation string of Rotational.Interfaces.Flange_a and Flange_b Apr 10, 2018
@beutlich beutlich added documentation Issue addresses the documentation and removed bug Critical/severe issue labels Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christiankral christiankral

@MartinOtter MartinOtter

Labels
documentation Issue addresses the documentation L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational
Projects
None yet
Milestone
MSL3.2.3
Development

No branches or pull requests
3 participants
@christiankral @MartinOtter @beutlich