Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CombiTable2D tests with unknown variables in reference results #2407

Closed
henrikt-ma opened this issue Dec 20, 2017 · 4 comments
Closed

CombiTable2D tests with unknown variables in reference results #2407

henrikt-ma opened this issue Dec 20, 2017 · 4 comments
Assignees
@GallLeo
Labels
L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined task General work that is not related to a bug or feature
Milestone
MSL3.2.3

Comments

@henrikt-ma
Copy link
Contributor

The following tests in RegressionTesting/ReferenceResults/MSL/trunk/ModelicaTest/Tables/CombiTable2D have unknown surface.y[…] variables in the reference results:

  • Test15
  • Test16
  • Test17

A suppose these come from a vendor specific implementation of ModelicaServices, and I guess the lists of comparison variables for these tests should simply be empty.
@beutlich beutlich added L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined task General work that is not related to a bug or feature labels Dec 20, 2017
@beutlich beutlich added this to the MSL_next-MINOR-version milestone Dec 20, 2017
@sjoelund
Copy link
Member

Only variables that are part of Modelica.Utilities.Internal.PartialModelicaServices.Animation.PartialSurface should be present, right?

@beutlich
Copy link
Member

Yes, but these variables are of no use for the regression here.

@sjoelund
Copy link
Member

Those are the only variables though...

@GallLeo
Copy link
Contributor

GallLeo commented Aug 27, 2018

I now emptied the list of comparison signals. As there are no public variables, I don't think result comparison does make a lot of sense for these test cases.

Ticket can be closed after upload of new reference results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GallLeo GallLeo

Labels
L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined task General work that is not related to a bug or feature
Projects
None yet
Milestone
MSL3.2.3
Development

No branches or pull requests
4 participants
@sjoelund @beutlich @GallLeo @henrikt-ma