Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation refers to non existing parameter startTime in Modelica.Blocks.Math.ContinuousMean, Variance and StandardDeviation #2495

Closed
tobolar opened this issue Mar 22, 2018 · 3 comments
Closed

Documentation refers to non existing parameter startTime in Modelica.Blocks.Math.ContinuousMean, Variance and StandardDeviation #2495

tobolar opened this issue Mar 22, 2018 · 3 comments
Assignees
@MartinOtter
Labels
documentation Issue addresses the documentation L: Blocks Issue addresses Modelica.Blocks V: 3.2.2 Issue originates in MSL v3.2.2 (and is not present in earlier releases)
Milestone
MSL3.2.3

Comments

@tobolar
Copy link
Contributor

tobolar commented Mar 22, 2018 •
edited by beutlich
Loading

In the documentation of Modelica.Blocks.Math.Variance and Modelica.Blocks.Math.StandardDeviation there is stated that "...the computation starts at startTime + t_eps..." but there is no public parameter like startTime. There is only protected t_0 in the Varianceblock.
@tobolar tobolar added enhancement New feature or enhancement L: Blocks Issue addresses Modelica.Blocks P: lowest Lowest priority issue labels Mar 22, 2018
@tobolar tobolar added this to the MSL3.2.3 milestone Mar 22, 2018
@beutlich
Copy link
Member

Also in ContinuousMean.

@beutlich beutlich removed P: lowest Lowest priority issue enhancement New feature or enhancement labels Apr 23, 2018
@beutlich beutlich mentioned this issue Apr 23, 2018
Closed
@beutlich beutlich changed the title Documentation refers to non existing parameter in Modelica.Blocks.Math.Variance Documentation refers to non existing parameter startTime in Modelica.Blocks.Math.ContinuousMean, Variance and StandardDeviation Apr 23, 2018
@beutlich beutlich added the V: 3.2.2 Issue originates in MSL v3.2.2 (and is not present in earlier releases) label Apr 23, 2018
@tobolar
Copy link
Contributor Author

tobolar commented Apr 25, 2018

If I understand the blocks' code well, what is meant with "startTime" is the experiment.StartTime annotation.

@beutlich
Copy link
Member

Yes, I got the same expression, but wondered why it is spelled different then.

@beutlich beutlich added the documentation Issue addresses the documentation label Apr 30, 2018
MartinOtter added a commit that referenced this issue May 22, 2018
@MartinOtter
#2495 fixed (documentation corrected: replaced startTime by <simulati…
02db8b2 
…on start time>)
MartinOtter added a commit that referenced this issue May 22, 2018
@MartinOtter
Merge pull request #2540 from modelica/otter-pull-request1
d568ea4 
#2495 fixed (documentation corrected: replaced startTime by <simulati…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinOtter MartinOtter

Labels
documentation Issue addresses the documentation L: Blocks Issue addresses Modelica.Blocks V: 3.2.2 Issue originates in MSL v3.2.2 (and is not present in earlier releases)
Projects
None yet
Milestone
MSL3.2.3
Development

No branches or pull requests
3 participants
@MartinOtter @tobolar @beutlich