Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing usage of Clock as a class name and component name #2945

Closed
qlambert-pro opened this issue May 21, 2019 · 4 comments · Fixed by #2947
Closed

Removing usage of Clock as a class name and component name #2945

qlambert-pro opened this issue May 21, 2019 · 4 comments · Fixed by #2947
Assignees
@beutlich
Labels
L: Blocks Issue addresses Modelica.Blocks L: Electrical.Digital Issue addresses Modelica.Electrical.Digital specification Issue (also) addresses the Modelica language specification task General work that is not related to a bug or feature
Milestone
MSL4.0.0

Comments

@qlambert-pro
Copy link
Contributor

qlambert-pro commented May 21, 2019 •
edited

I would like to propose that we modify the MSL to not use Clock as a class name. This would resolve some ambiguities for the user, and make it possible for the language design group to make Clock a keyword of the Modelica language.

Conversion rules would make that change somewhat easier.
@beutlich beutlich added the specification Issue (also) addresses the Modelica language specification label May 21, 2019
@beutlich beutlich added the L: Blocks Issue addresses Modelica.Blocks label May 21, 2019
@beutlich beutlich assigned beutlich and unassigned bernhard-thiele May 21, 2019
@beutlich beutlich added the L: Electrical.Digital Issue addresses Modelica.Electrical.Digital label May 21, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone May 21, 2019
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue May 21, 2019
@beutlich
refs modelica#2945: Convert Clock
316b13f
@beutlich beutlich mentioned this issue May 21, 2019
Merged
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue May 22, 2019
@beutlich
refs modelica#2945: Remove defaultComponentName again
cb808f2
@beutlich
Copy link
Member

@daiwen Should modelica/ModelicaSpecification#2280 be reopened?

@henrikt-ma
Copy link
Contributor

Before reopening modelica/ModelicaSpecification#2280, I suggest a small scope creep of this issue to cover all introduced Clock identifiers in the MSL. As long as the MSL has components called Clock, there's still nothing we can do about it's keyword status.

@qlambert-pro
Copy link
Contributor Author

qlambert-pro commented May 23, 2019 •
edited

I hadn't seen the case of component names but Henrik is right, we can't reopen modelica/ModelicaSpecification#2280 until there are still occurrences of Clock, whatever they maybe.
I can open a new issue if you'd prefer me doing it that way.

@beutlich
Copy link
Member

OK, I got it.

beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue May 26, 2019
@beutlich
refs modelica#2945: Convert more Clock components
57d0a87
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue May 26, 2019
@beutlich
refs modelica#2945: Rename Clock instance name
bd4fadc
@beutlich beutlich changed the title Removing usage of Clock as a class name in MSL Removing usage of Clock as a class name and component name May 26, 2019
@beutlich beutlich added the task General work that is not related to a bug or feature label May 27, 2019
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue May 28, 2019
@beutlich
refs modelica#2945: Fix description
951516b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beutlich beutlich

Labels
L: Blocks Issue addresses Modelica.Blocks L: Electrical.Digital Issue addresses Modelica.Electrical.Digital specification Issue (also) addresses the Modelica language specification task General work that is not related to a bug or feature
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging a pull request may close this issue.

Convert Clock beutlich/ModelicaStandardLibrary
4 participants
@qlambert-pro @bernhard-thiele @beutlich @henrikt-ma