Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise documentation on (and possibly implementation of) StateSelection #2946

Open
beutlich opened this issue May 21, 2019 · 2 comments
Open

Revise documentation on (and possibly implementation of) StateSelection #2946

beutlich opened this issue May 21, 2019 · 2 comments
Assignees
@tobolar
Labels
L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational

Comments

@beutlich
Copy link
Member

beutlich commented May 21, 2019 •
edited

Modelica.Mechanics.Translational.UsersGuide.StateSelection and Modelica.Mechanics.Rotational.UsersGuide.StateSelection speak about the error control of unbounded absolute state variables:

ModelicaStandardLibrary/Modelica/Mechanics/Translational.mo

Line 380 in 6aa5f83

Currently, in Modelica there is no possibility to provide this information.

and

ModelicaStandardLibrary/Modelica/Mechanics/Rotational.mo

Line 478 in 6aa5f83

Currently, in Modelica there is no possibility to provide this information.

respectively. However, with the Modelica Language Specification 3.4 the unbounded attribute for Real variables was introduced, such that at least the paragraphs on StateSelection need to be reworded.

See also #2867.

And I actually wonder if there is any more impact than just on the documentation. Can we also improve the implementation (and remove the advanced nominal parameters)?
@beutlich beutlich added L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational labels May 21, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone May 21, 2019
@beutlich beutlich mentioned this issue Jul 16, 2019
Merged
@beutlich
Copy link
Member Author

beutlich commented Nov 2, 2019

@MartinOtter @tobolar Any feedback?

@MartinOtter MartinOtter removed their assignment Jan 9, 2020
@beutlich beutlich removed this from the MSL4.0.0 milestone Jan 24, 2020
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Jan 26, 2020
@beutlich
refs modelica#2946: Update reasoning on library design
2e7d740
@beutlich beutlich mentioned this issue Jan 26, 2020
Merged
@beutlich
Copy link
Member Author

beutlich commented Jan 26, 2020 •
edited

This issue was not considered (important enough) by the library officers. At least #3369 updates the outdated documentation.

dietmarw pushed a commit that referenced this issue Jan 27, 2020
@beutlich @dietmarw
refs #2946: Update reasoning on library design (#3369)
1703e5b
@beutlich beutlich mentioned this issue Apr 29, 2020
Open
@beutlich beutlich mentioned this issue Oct 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobolar tobolar

Labels
L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MartinOtter @tobolar @beutlich