Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questionable conversion proposition in Spice3.Internal.MOS2 #3015

Closed
beutlich opened this issue Jul 1, 2019 · 1 comment · Fixed by #3139
Closed

Questionable conversion proposition in Spice3.Internal.MOS2 #3015

beutlich opened this issue Jul 1, 2019 · 1 comment · Fixed by #3139
Assignees
Labels
L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3 question Unexplained or undecided issue
Milestone

Comments

@beutlich
Copy link
Member

beutlich commented Jul 1, 2019

When trying to remove the obsolete variables icqmGB, icqmGS, icqmGD, vDS, qm and cc_obsolete from Modelica.Electrical.Spice3.Internal.MOS2 I stumbled accross the following comment

//--------------------------------------------------------------------------------------
//need to be Boolean instead of integer, will be changed with the next Modelica version
//via converting script
parameter Integer OFF = 0
"Optional initial condition: 0 - IC not used, 1 - IC used, not implemented yet";
//--------------------------------------------------------------------------------------

What exactly is the conversion proposition? I believe it is impossible to convert only the type of OFF from Integer to Boolean.

@beutlich beutlich added question Unexplained or undecided issue L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3 labels Jul 1, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Jul 1, 2019
@beutlich
Copy link
Member Author

beutlich commented Jul 1, 2019

We simply could add min/max attributes and avoid the whole conversion hassle (since it also is not implemented yet).

parameter Integer OFF(min=0, max=1) = 0
  "Optional initial condition: 0 - IC not used, 1 - IC used, not implemented yet";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3 question Unexplained or undecided issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants