Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change parameter freqHz to f #3035

Closed
christiankral opened this issue Jul 12, 2019 · 5 comments
Closed

Change parameter freqHz to f #3035

christiankral opened this issue Jul 12, 2019 · 5 comments
Assignees
@christiankral @AHaumer
Labels
L: Blocks Issue addresses Modelica.Blocks L: Electrical.Analog Issue addresses Modelica.Electrical.Analog L: Electrical.Polyphase Issue addresses Modelica.Electrical.Polyhase
Milestone
MSL4.0.0

Comments

@christiankral
Copy link
Contributor

The parameter freqHz of the sinusoidal voltage sources of

  • Modelica.Electrical.Analog.Sources
  • Modelica.Electrical.MultiPhase.Sources

shall be changed to f
@christiankral christiankral added L: Electrical.Analog Issue addresses Modelica.Electrical.Analog L: Electrical.MultiPhase Issue addresses Modelica.Electrical.MultiPhase labels Jul 12, 2019
@christiankral christiankral added this to the MSL4.0.0 milestone Jul 12, 2019
@christiankral
Copy link
Contributor Author

Before doing this ticket, #2973 shall be done.

@AHaumer
Copy link
Contributor

AHaumer commented Jul 13, 2019

In favour!

@beutlich
Copy link
Member

Before doing this ticket, #2973 shall be done.

Merged.

@christiankral christiankral added the L: Blocks Issue addresses Modelica.Blocks label Jul 15, 2019
@christiankral
Copy link
Contributor Author

This issue also affects the following components in Modelica.Blocks.Sources

  • Sine
  • Cosine
  • ExpSine

christiankral added a commit to christiankral/ModelicaStandardLibrary that referenced this issue Jul 15, 2019
@christiankral
Refs modelica#3035: Change freqHz to f in sources
aad9cc6
@christiankral christiankral mentioned this issue Jul 15, 2019
Merged
christiankral added a commit to christiankral/ModelicaStandardLibrary that referenced this issue Jul 15, 2019
@christiankral
Add conversion test examples for modelica#3035
84ad333
beutlich pushed a commit to christiankral/ModelicaStandardLibrary that referenced this issue Jul 15, 2019
@christiankral @beutlich
Refs modelica#3035: Change freqHz to f in sources
3134b0a
beutlich pushed a commit to christiankral/ModelicaStandardLibrary that referenced this issue Jul 15, 2019
@christiankral @beutlich
Add conversion test examples for modelica#3035
05f0b79
beutlich added a commit to christiankral/ModelicaStandardLibrary that referenced this issue Jul 15, 2019
@beutlich
refs modelica#3035: Convert freqHz to f
08255d7
beutlich added a commit to christiankral/ModelicaStandardLibrary that referenced this issue Jul 15, 2019
@beutlich
refs modelica#3035: Add StopTime annotation
8523b1d
@beutlich
Copy link
Member

Resolved by #3046.

@beutlich beutlich added L: Electrical.Polyphase Issue addresses Modelica.Electrical.Polyhase and removed L: Electrical.MultiPhase Issue addresses Modelica.Electrical.MultiPhase labels Jul 17, 2019
@beutlich beutlich mentioned this issue Oct 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christiankral christiankral

@AHaumer AHaumer

Labels
L: Blocks Issue addresses Modelica.Blocks L: Electrical.Analog Issue addresses Modelica.Electrical.Analog L: Electrical.Polyphase Issue addresses Modelica.Electrical.Polyhase
Projects
None yet
Milestone
MSL4.0.0
Development

No branches or pull requests
3 participants
@christiankral @AHaumer @beutlich