Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singular inconsistent scalar system for SaturatingInductor #3064

Closed
AHaumer opened this issue Jul 20, 2019 · 3 comments · Fixed by #3066
Closed

Singular inconsistent scalar system for SaturatingInductor #3064

AHaumer opened this issue Jul 20, 2019 · 3 comments · Fixed by #3066
Assignees
Labels
bug Critical/severe issue L: Electrical.Analog Issue addresses Modelica.Electrical.Analog P: highest Highest priority issue
Milestone

Comments

@AHaumer
Copy link
Contributor

AHaumer commented Jul 20, 2019

I found the above mentioned bug, when current through the saturatingInductor goes rather smoothly and slowly through zero - see enclosed example.
TestSaturatingInductor.zip
Investigating the problem, I don't think this is a tool issue, it's a problem of the implemenation. Well I have to admit I implemented this model back in 2004. Honestly I don't know since which release we're living with that bug - in many cases this bug won't appear. However, MSL should be "clean" in as many cases as possible.
I had to dig into modeling of saturation but I found a solution. After discussion and decision with @christiankral about details of the implementation I'll provide a bug fix for maint\3.2.3 and for 4.0.0-dev in 2 PRs before my vacation (during August).

@AHaumer AHaumer added bug Critical/severe issue L: Electrical.Analog Issue addresses Modelica.Electrical.Analog P: highest Highest priority issue V: 3.2.3 Issue originates in MSL v3.2.3 (and is not present in earlier releases) labels Jul 20, 2019
@AHaumer AHaumer added this to the MSL3.2.3+maint milestone Jul 20, 2019
@AHaumer AHaumer self-assigned this Jul 20, 2019
@beutlich
Copy link
Member

I don't think this is a tool issue, it's a problem of the implemenation.

The TestSaturatingInductor runs nicely in SimulationX 4.0.2 with both DAE or ODE solver.

grafik

@beutlich beutlich changed the title Singular inconsistent scalar system for saturatingInductor Singular inconsistent scalar system for SaturatingInductor Jul 20, 2019
@beutlich
Copy link
Member

I'll provide a bug fix for maint\3.2.3

Since we do not have a detailed git branching model, no commits should go to maint\3.2.3 while MSL v3.2.3+build.3 is not yet relased, i.e., no commits before 2019-09-18. You still can create PRs though,

@AHaumer
Copy link
Contributor Author

AHaumer commented Jul 20, 2019

The bugfix should definitely go to the next release ...
Anyhow, I'll provide a PR for 3.2.3 and another one for 4.0.0-dev.

AHaumer added a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Jul 20, 2019
AHaumer added a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Jul 20, 2019
AHaumer added a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Jul 20, 2019
@beutlich beutlich removed the V: 3.2.3 Issue originates in MSL v3.2.3 (and is not present in earlier releases) label Jul 23, 2019
@beutlich beutlich modified the milestones: MSL3.2.3+maint, MSL4.0.0 Jul 23, 2019
christiankral added a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Jul 24, 2019
beutlich added a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Oct 20, 2019
beutlich added a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Oct 20, 2019
beutlich added a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Oct 20, 2019
beutlich pushed a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Oct 20, 2019
beutlich pushed a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Oct 20, 2019
beutlich added a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Oct 20, 2019
beutlich added a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Oct 20, 2019
beutlich added a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Oct 20, 2019
beutlich added a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Oct 20, 2019
beutlich added a commit that referenced this issue Oct 20, 2019
beutlich pushed a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Oct 20, 2019
beutlich pushed a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Oct 20, 2019
beutlich pushed a commit that referenced this issue Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: Electrical.Analog Issue addresses Modelica.Electrical.Analog P: highest Highest priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants