Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change of DC machine record dialog #3079

Closed
christiankral opened this issue Jul 29, 2019 · 2 comments
Closed

Change of DC machine record dialog #3079

christiankral opened this issue Jul 29, 2019 · 2 comments
Assignees
@christiankral
Labels
documentation Issue addresses the documentation L: Electrical.Machines Issue addresses Modelica.Electrical.Machines
Milestone
MSL4.0.0

Comments

@christiankral
Copy link
Contributor

Changes of #3072 shall also be applied to the parameter records of the DC machines.
@christiankral christiankral added L: Electrical.Machines Issue addresses Modelica.Electrical.Machines documentation Issue addresses the documentation labels Jul 29, 2019
@christiankral christiankral added this to the MSL4.0.0 milestone Jul 29, 2019
@christiankral christiankral self-assigned this Jul 29, 2019
@beutlich
Copy link
Member

As a hint - since you self-assigned this issue: It would be OK to only create the PR w/o creating a connected issue first.

@christiankral
Copy link
Contributor Author

christiankral commented Jul 30, 2019 •
edited

Thanks for the hint. I would usually create just a PR for small issues. Yesterday I had no time to perform the PR even though it's not much work. I yet wanted to keep the information somewhere.

christiankral added a commit to christiankral/ModelicaStandardLibrary that referenced this issue Jul 30, 2019
@christiankral
Refs modelica#3079: Change "Nominal resistances and inductances" to "…
fb3c810 
…Armature"

And fix wrong speed reference temperatures in doc string
@christiankral christiankral mentioned this issue Jul 30, 2019
Merged
beutlich pushed a commit that referenced this issue Jul 30, 2019
@christiankral @beutlich
Change tab name of DC machine record (#3080)
8cd7e8b 
* Refs #3079: Change "Nominal resistances and inductances" to "Armature" 

And fix wrong speed reference temperatures in doc string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christiankral christiankral

Labels
documentation Issue addresses the documentation L: Electrical.Machines Issue addresses Modelica.Electrical.Machines
Projects
None yet
Milestone
MSL4.0.0
Development

No branches or pull requests
2 participants
@christiankral @beutlich