Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong unit in ModelicaTest.Fluid.Dissipation.Verifications.PressureLoss.Bend examples #3127

Closed
carlj-w opened this issue Oct 1, 2019 · 2 comments · Fixed by #3301
Closed
Assignees
Labels
L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined
Milestone

Comments

@carlj-w
Copy link
Contributor

carlj-w commented Oct 1, 2019

In ModelicaTest.Fluid.Dissipation.Verifications.PressureLoss.Bend.dp_curvedOverall_DPMFLOW we have this line:
parameter Modelica.SIunits.Conversions.NonSIunits.Angle_deg delta[3] = {30, 45, 90} * Modelica.Constants.pi / 180 "Angle of turning";
and in ModelicaTest.Fluid.Dissipation.Verifications.PressureLoss.Bend.dp_edgedOverall_DPMFLOW this line:
parameter Modelica.SIunits.Conversions.NonSIunits.Angle_deg delta[4] = {30, 45, 90, 180} * Modelica.Constants.pi / 180 "Angle of turning";

it seems to me that both right hand sides converts angles from degrees to radians, so the result is in radians. However, the variables on the left hand sides have their units set to degrees.

@beutlich beutlich added L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined question Unexplained or undecided issue labels Oct 1, 2019
@wischhusen
Copy link
Contributor

Correct. Should be SIunits.Angle.

@dietmarw
Copy link
Member

dietmarw commented Oct 2, 2019

@wischhusen If you do not mind then I like to use the opportunity of this trivial bug to create a screencast of how to fix issues in the MSL and how to submit a PR. So simply leave this to me :-)

@dietmarw dietmarw assigned dietmarw and unassigned wischhusen Oct 2, 2019
@beutlich beutlich removed the question Unexplained or undecided issue label Oct 23, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Oct 23, 2019
dietmarw added a commit to dietmarw/ModelicaStandardLibrary that referenced this issue Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants