Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an arrow to icon of SweptVolume? #3164

Closed
sergniko opened this issue Oct 22, 2019 · 4 comments
Closed

Add an arrow to icon of SweptVolume? #3164

sergniko opened this issue Oct 22, 2019 · 4 comments
Assignees
@christiankral
Labels
icon Issues addresses the icon graphics L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) question Unexplained or undecided issue
Milestone
MSL4.0.0

Comments

@sergniko
Copy link

Is it a good idea to add an arrow to Fluid.SweptVolume as for most of Translational.Components?
In class documentation it is said: "The force of the flange results from the pressure difference between medium and ambient pressure and the cross sectional piston area". But nothing about sign convention.
For me, as a new user, it took a lot of time to understand why the force is negative while the pressure is above ambient pressure.
Adding arrow can help to get better understanding. For example Translational.Examples.WhyArrows is very helpful.
@beutlich beutlich added enhancement New feature or enhancement L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) labels Oct 22, 2019
@beutlich
Copy link
Member

@christiankral As we no longer have active library officers for Fluid and as @sergniko referred to Mechanical.Translational, could you please take care of it? Thanks a lot.

@beutlich beutlich added the question Unexplained or undecided issue label Oct 22, 2019
@beutlich beutlich changed the title Add an arrow to SweptVolume? Add an arrow to icon of SweptVolume? Oct 22, 2019
christiankral added a commit to christiankral/ModelicaStandardLibrary that referenced this issue Feb 15, 2020
@christiankral
Add translational arrow to SweptVolume
847a629 
Refs modelica#3164
@christiankral christiankral mentioned this issue Feb 15, 2020
Merged
@christiankral
Copy link
Contributor

I somehow missed this issue because of the focus on MSL 4.0.0.

From investigating ModelicaTest.Fluid.TestComponents.Machines.TestSweptVolume

image

image

So I had a look at Modelica.Fluid.Machines.SweptVolume and created PR #3428 to include an arrow.

@dietmarw dietmarw added this to the MSL4.0.0 milestone Feb 17, 2020
dietmarw pushed a commit that referenced this issue Feb 17, 2020
@christiankral
Add translational reference direction arrow to SweptVolume model (#3428)
1e9fab7 
* Add translational arrow to SweptVolume
Refs #3164
@dietmarw
Copy link
Member

fixed in #3428

@beutlich beutlich added icon Issues addresses the icon graphics and removed enhancement New feature or enhancement labels Feb 22, 2020
@sergniko
Copy link
Author

sergniko commented Feb 7, 2021

The arrow is missing again in latest build/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christiankral christiankral

Labels
icon Issues addresses the icon graphics L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) question Unexplained or undecided issue
Projects
None yet
Milestone
MSL4.0.0
Development

No branches or pull requests
4 participants
@dietmarw @christiankral @sergniko @beutlich