Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Modelica.Media.Common.OneNonLinearEquation? #3205

Closed
beutlich opened this issue Nov 6, 2019 · 2 comments · Fixed by #3207
Closed

Update Modelica.Media.Common.OneNonLinearEquation? #3205

beutlich opened this issue Nov 6, 2019 · 2 comments · Fixed by #3207
Assignees
@beutlich
Labels
enhancement New feature or enhancement L: Media Issue addresses Modelica.Media
Milestone
MSL4.0.0

Comments

@beutlich
Copy link
Member

beutlich commented Nov 6, 2019

@HansOlsson When Modelica.Media.Common.OneNonLinearEquation was invented some 15 years ago, there have been a lot of restrictions on both Dymola and the Modelica language.

ModelicaStandardLibrary/Modelica/Media/package.mo

Lines 8610 to 8613 in 1ddb4fb

This function should currently only be used in Modelica.Media,
since it might be replaced in the future by another strategy,
where the tool is responsible for the solution of the non-linear
equation.

ModelicaStandardLibrary/Modelica/Media/package.mo

Lines 8639 to 8642 in 1ddb4fb

Due to current limitations of the
Modelica language (not possible to pass a function reference to a function),
the construction to use this solver on a user-defined function is a bit
complicated (this method is from Hans Olsson, Dassault Systèmes AB). A user has to

This clearly is outdated and certainly can be improved? What can be done here for MSL v4.0.0 (or later) to make use of the improved Modelica tools and language?
@beutlich beutlich added question Unexplained or undecided issue L: Media Issue addresses Modelica.Media labels Nov 6, 2019
@beutlich beutlich added the enhancement New feature or enhancement label Nov 6, 2019
@beutlich
Copy link
Member Author

beutlich commented Nov 6, 2019

Got it, Modelica.Math.Nonlinear.solveOneNonlinearEquation (introduced by 613505f for MSL v3.2) is the way to go.

beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Nov 7, 2019
@beutlich
refs modelica#3205: Replace OneNonLinearEquation by solveOneNonlinear…
3a5991f 
…Equation
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Nov 7, 2019
@beutlich
refs modelica#3205: Also test saturationTemperature
c843477
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Nov 7, 2019
@beutlich
refs modelica#3205: Add conversion message
fd9af0f
@beutlich beutlich mentioned this issue Nov 7, 2019
Merged
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Nov 7, 2019
@beutlich
refs modelica#3205: Replace OneNonLinearEquation by solveOneNonlinear…
5067943 
…Equation
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Nov 7, 2019
@beutlich
refs modelica#3205: Also test saturationTemperature
938fba9
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Nov 7, 2019
@beutlich
refs modelica#3205: Add conversion message
b7cbe8a
@beutlich beutlich added this to the MSL4.0.0 milestone Nov 7, 2019
@beutlich beutlich assigned beutlich and unassigned HansOlsson Nov 7, 2019
@beutlich
Copy link
Member Author

beutlich commented Nov 7, 2019

Addressed by #3207.

@beutlich beutlich removed the question Unexplained or undecided issue label Nov 7, 2019
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Nov 8, 2019
@beutlich
refs modelica#3205: Replace OneNonLinearEquation by solveOneNonlinear…
a5c4656 
…Equation
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Nov 8, 2019
@beutlich
refs modelica#3205: Also test saturationTemperature
2a22b3e
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Nov 8, 2019
@beutlich
refs modelica#3205: Add conversion to obsoleted package
710ef21
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Nov 11, 2019
@beutlich
refs modelica#3205: Update documentation
8459557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beutlich beutlich

Labels
enhancement New feature or enhancement L: Media Issue addresses Modelica.Media
Projects
None yet
Milestone
MSL4.0.0
2 participants
@HansOlsson @beutlich