Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messed up section numbers in MoMoLib_VerificationResults_XRG.pdf #3316

Closed
beutlich opened this issue Jan 14, 2020 · 3 comments · Fixed by #3395
Closed

Messed up section numbers in MoMoLib_VerificationResults_XRG.pdf #3316

beutlich opened this issue Jan 14, 2020 · 3 comments · Fixed by #3395
Assignees
@wischhusen
Labels
L: Media Issue addresses Modelica.Media L: Resources Issue addresses Modelica/Resources (excl. C-Sources)
Milestone
MSL4.0.0

Comments

@beutlich
Copy link
Member

beutlich commented Jan 14, 2020 •
edited

When trying to understand the R134a verification of MoMoLib vs. RefProp for #3276 by reading MoMoLib_VerificationResults_XRG.pdf, I noticed that the heading numbers are messed up for subsections of section 2.1.

If we fix it, we should also emphasize, that this then is an updated document and no longer the original document handed in as Clean Sky report.
@beutlich beutlich added L: Media Issue addresses Modelica.Media L: Resources Issue addresses Modelica/Resources (excl. C-Sources) labels Jan 14, 2020
@beutlich beutlich changed the title Messed up section numbers for MoMoLib_VerificationResults_XRG.pdf Messed up section numbers in MoMoLib_VerificationResults_XRG.pdf Jan 14, 2020
@wischhusen
Copy link
Contributor

Resolved. Pushed a new pdf to my fork.

@beutlich
Copy link
Member Author

beutlich commented Feb 5, 2020

The PDF you added by wischhusen@e33c605 only contains 17 pages whereas the previous version contained 24 pages. Can you please create a full PDF that still contains the sections 3 and 4.

@wischhusen
Copy link
Contributor

Sorry, I added the missing parts.

@beutlich beutlich added this to the MSL4.0.0 milestone Feb 6, 2020
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Feb 6, 2020
@beutlich
refs modelica#3316: Fix section numbers
6f9a81a
@beutlich beutlich mentioned this issue Feb 6, 2020
Merged
beutlich added a commit that referenced this issue Feb 7, 2020
@beutlich
refs #3316: Fix section numbers (#3395)
3b3986e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wischhusen wischhusen

Labels
L: Media Issue addresses Modelica.Media L: Resources Issue addresses Modelica/Resources (excl. C-Sources)
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging a pull request may close this issue.

Fix section numbers in MoMoLib_VerificationResults_XRG.pdf beutlich/ModelicaStandardLibrary
2 participants
@wischhusen @beutlich