Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and remove icons from Modelica.Icons #340

Closed
modelica-trac-importer opened this issue Jan 14, 2017 · 16 comments · Fixed by #3016
Closed

Rename and remove icons from Modelica.Icons #340

modelica-trac-importer opened this issue Jan 14, 2017 · 16 comments · Fixed by #3016
Assignees
Labels
L: Icons Issue addresses Modelica.Icons task General work that is not related to a bug or feature
Milestone

Comments

@modelica-trac-importer
Copy link

Reported by christiankral on 26 Mar 2010 06:27 UTC
At the 66th design meeting in Hamburg Harburg it was decided to incorporate fully backwards compatible icons. With the next conversion script in MSL 4.0 the following changes shall be applied:

The following icons of Modelica.Icons shall be renamed

  • Icons.RotationalSensor -> Icons.RoundSensor
  • Icons.TranslationalSensor -> Icons.RectangularSensor

The following icons shall be removed (left side) and instead other icons (right side) shall be used

  • Icons.Info -> Icons.Information
  • Icons.Library -> Icons.Package
  • Icons.Library2 -> Icons.Package

The following icons shall be indicated as deprecated

  • Icons.MotorIcon
  • Icons.GearIcon

Migrated-From: https://trac.modelica.org/Modelica/ticket/340

@modelica-trac-importer
Copy link
Author

Modified by christiankral on 26 Mar 2010 06:27 UTC

@modelica-trac-importer modelica-trac-importer added the L: Icons Issue addresses Modelica.Icons label Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by otter on 16 Jul 2010 09:50 UTC
The proposal:

The following icons shall be indicated as deprecated

    * Icons.MotorIcon
    * Icons.GearIcon 

is not good. These icons are used in user models (it is therefore not possible to remove them) and it is useful to have these icons. However, these icons should be moved to the corresponding domain-specific library (Rotational).

@modelica-trac-importer
Copy link
Author

Modified by otter on 18 Jul 2013 11:53 UTC

@modelica-trac-importer
Copy link
Author

Changelog removed by otter on 18 Jul 2013 11:53 UTC

@modelica-trac-importer modelica-trac-importer added enhancement New feature or enhancement and removed bug Critical/severe issue labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 1 Aug 2015 21:36 UTC
Milestone renamed

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 1 Aug 2015 21:39 UTC
Milestone renamed

@modelica-trac-importer modelica-trac-importer added this to the MSL_next-MAJOR-version milestone Jan 14, 2017
@tobolar
Copy link
Contributor

tobolar commented Feb 5, 2018

For MotorIcon, there exists Modelica.Mechanics.MultiBody.Icons.MotorIcon, and for GearIcon, there is Modelica.Mechanics.Rotational.Icons.Gearbox. Thus, both Icons.MotorIcon and Icons.GearIcon could be marked as obsolete.

@HansOlsson
Copy link
Contributor

For MotorIcon, there exists Modelica.Mechanics.MultiBody.Icons.MotorIcon, and for GearIcon, there is 'Modelica.Mechanics.Rotational.Icons.Gearbox'. Thus, both Icons.MotorIcon and Icons.GearIcon could be marked as obsolete.

Or in a new version with conversion scripts they can be removed, and user models converted to the appropriate ones.

Looking in some commercial libraries I note that they already use Modelica.Mechanics.Rotational.Icons.Gear instead of Modelica.Icons.GearIcon. (I did not find any use of either MotorIcon outside of MSL).

@tobolar
Copy link
Contributor

tobolar commented Feb 5, 2018

Additionally, icon Modelica.Mechanics.MultiBody.Icons.MotorIcon should be renamed to 'Motor' only.

@christiankral
Copy link
Contributor

I have two comments/suggestions here:

  1. In electrical engineering we call it machine, not motor, since a machine can be operated as motor or generator. Example: If an electric machine in a robotic application brakes electrically, it is operated as generator. I wonder if mechanical engineers use and understand the term machine in the same way. If yes, the icon could be called Machine instead of Motor. However, if mechanical engineers use the term motor, it is an electric motor, isn't it? Or could it be a hydraulic motor that this particular icon is used for?

  2. Unify icon design: I think we could even consider to make the Multibody motor icon look more like the ones in Modelica.Electrical.Machines.Icons. One could copy one of these icons an make the housing color red to match the actual icon color.

@tobolar
Copy link
Contributor

tobolar commented Feb 8, 2018

@christiankral

  1. I think the common name in the mechanical engineering is (electric) drive since in most cases it is used as a power delivering unit. The name is used even if the machine could recuperate the energy.

  2. To use an icon from Modelica.Electrical.Machines.Icons would be reasonable, especially if there would be some kind of "basic" icon for those purposes.
    Even better, the robot example would use a machine directly from Modelica.Electrical.Machines package, i.e. we don't use any machine model designed only for that particular case (Modelica.Mechanics.MultiBody.Examples.Systems.RobotR3.Components.Motor).
    On the contrary, a bearing friction model from Modelica.Mechanics.Rotational.Components should be used within the machines. (Optionally, we can move Modelica.Electrical.Machines.Losses.Friction to Modelica.Mechanics.Rotational.Components and modify it to be consistent with other components.)

@beutlich beutlich assigned christiankral and tobolar and unassigned d-hedberg Mar 23, 2018
@christiankral
Copy link
Contributor

Clarification: in electrical engineering we call drive a motor + power electronics + control, so I assume this is very much in line with on how mechanical and robotic engineers use the term.

christiankral added a commit that referenced this issue May 21, 2018
@christiankral
Copy link
Contributor

@tobolar I created a generic machine and drive icon in fbb74f8:

  • Modelica.Electrical.Machines.Icons.Machine (left)
  • Modelica.Electrical.Machines.Icons.Drive (right)

image

The generic icons are gray which should match the rotational and multi body color scheme approximately.

The shape of the machine icon is fully in line with all other electric machine icons.

@dietmarw
Copy link
Member

dietmarw commented Jun 5, 2018

Is this issue now resolved. It looks like it to me?

@tobolar
Copy link
Contributor

tobolar commented Jun 5, 2018

I don't believe so. It is aimed for next major version at the earliest.

@dietmarw
Copy link
Member

dietmarw commented Jun 5, 2018

Ah yes of course. I only saw the latest additions.

@dietmarw dietmarw closed this as completed Jun 5, 2018
@dietmarw dietmarw reopened this Jun 5, 2018
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Jul 1, 2019
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Jul 6, 2019
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Jul 17, 2019
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Jul 18, 2019
beutlich added a commit that referenced this issue Jul 18, 2019
@beutlich beutlich added task General work that is not related to a bug or feature and removed enhancement New feature or enhancement labels Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Icons Issue addresses Modelica.Icons task General work that is not related to a bug or feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants