-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename and remove icons from Modelica.Icons #340
Comments
Modified by christiankral on 26 Mar 2010 06:27 UTC |
Comment by otter on 16 Jul 2010 09:50 UTC
is not good. These icons are used in user models (it is therefore not possible to remove them) and it is useful to have these icons. However, these icons should be moved to the corresponding domain-specific library (Rotational). |
Modified by otter on 18 Jul 2013 11:53 UTC |
Changelog removed by otter on 18 Jul 2013 11:53 UTC |
Comment by dietmarw on 1 Aug 2015 21:36 UTC |
Comment by dietmarw on 1 Aug 2015 21:39 UTC |
For MotorIcon, there exists |
Or in a new version with conversion scripts they can be removed, and user models converted to the appropriate ones. Looking in some commercial libraries I note that they already use Modelica.Mechanics.Rotational.Icons.Gear instead of Modelica.Icons.GearIcon. (I did not find any use of either MotorIcon outside of MSL). |
Additionally, icon |
I have two comments/suggestions here:
|
|
Clarification: in electrical engineering we call drive a motor + power electronics + control, so I assume this is very much in line with on how mechanical and robotic engineers use the term. |
@tobolar I created a generic machine and drive icon in fbb74f8:
The generic icons are gray which should match the rotational and multi body color scheme approximately. The shape of the machine icon is fully in line with all other electric machine icons. |
Is this issue now resolved. It looks like it to me? |
I don't believe so. It is aimed for next major version at the earliest. |
Ah yes of course. I only saw the latest additions. |
Reported by christiankral on 26 Mar 2010 06:27 UTC
At the 66th design meeting in Hamburg Harburg it was decided to incorporate fully backwards compatible icons. With the next conversion script in MSL 4.0 the following changes shall be applied:
The following icons of
Modelica.Icons
shall be renamedIcons.RotationalSensor
->Icons.RoundSensor
Icons.TranslationalSensor
->Icons.RectangularSensor
The following icons shall be removed (left side) and instead other icons (right side) shall be used
Icons.Info
->Icons.Information
Icons.Library
->Icons.Package
Icons.Library2
->Icons.Package
The following icons shall be indicated as deprecated
Icons.MotorIcon
Icons.GearIcon
Migrated-From: https://trac.modelica.org/Modelica/ticket/340
The text was updated successfully, but these errors were encountered: