Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jumps in signal at very tiny time intervals in PolyphaseTwoLevel_RL reference results #3523

Closed
maltelenz opened this issue Mar 24, 2020 · 9 comments · Fixed by #4167
Closed
Assignees
Labels
example Issue only addresses example(s) L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters ref-result Issue addresses the reference results
Milestone

Comments

@maltelenz
Copy link
Contributor

maltelenz commented Mar 24, 2020

In the reference results for Modelica.Electrical.PowerConverters.Examples.DCAC.PolyphaseTwoLevel.PolyphaseTwoLevel_RL there are two subsequent jumps at an extremely short distance from each other. You can see this in rows 3433-3436 in the linked csv file (can't direct link because github restrictions on file size).

The variables in question are voltageSensor.v[1] through voltageSensor.v[3]. Plotted:
image
Please ignore the labeling on the x axis (bug in SystemModeler).

As you can see, SystemModeler (blue) only has a single event iteration leading to the complete jump, while the reference result (orange) takes two jumps very close to each other.
The reference reports jumps at 0.030250000000000003 and 0.030250000000115126, a distance of approximately 1.15e-13 apart.

Is there anything in the model that explains the two separate jumps? Is it expected? Do other tools reproduce these two jumps?

@maltelenz maltelenz added this to the MSL4.0.0 milestone Mar 24, 2020
@maltelenz maltelenz added the L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters label Mar 24, 2020
@AHaumer
Copy link
Contributor

AHaumer commented Mar 25, 2020

I can't reproduce that with Dymola, I can't zoom in beyond a resolution of ~1e-7.
I can't say that this is expected, but IMHO it's possible - depending on tolerance and event handling.
There are time events (fundemantalWaveVoltage, fundemantalWaveCurrent, signalPWM) and state events (signalPWM, inverter). It could happen that a state event is iterated within a very short time span before or after a time event and both results are stored. Does the behaviour change with another choice of the solver and / or the tolerance?
Is the difference marked by the comparison tool?
IMHO it's neglectible. Sorry I don't have time to dig deeper - we are 150% busy organizing online content for our students.

@AHaumer AHaumer removed their assignment Mar 25, 2020
@beutlich beutlich added the example Issue only addresses example(s) label Mar 30, 2020
@beutlich beutlich added the worksforme Clarified issue label Apr 27, 2020
@beutlich
Copy link
Member

beutlich commented Apr 27, 2020

Closing as worksforme, finally.

@henrikt-ma
Copy link
Contributor

Instead of closing as worksforme, shouldn't the correct action be to remove the voltageSensors.v signals from the comparison variables? It would comply with @AHaumer's suggestion to not dig deeper, and would still leave us with 44 less problematic variables to be compared.

@henrikt-ma henrikt-ma reopened this Jan 14, 2021
@beutlich beutlich modified the milestones: MSL4.0.0, MSL4.1.0 Jan 14, 2021
@beutlich beutlich added ref-result Issue addresses the reference results and removed worksforme Clarified issue labels Jan 23, 2021
@TManikantan
Copy link
Contributor

TManikantan commented Mar 9, 2023

@christiankral Hi ,I recently assumed the role of Project Deputy, would you please take time to look at it? Do contact me for any help that I could provide with this ticket.

@TManikantan
Copy link
Contributor

@christiankral @AHaumer what is your suggestion for this issue?Do you agree with #3523 (comment)

@TManikantan
Copy link
Contributor

As per suggestion from @henrikt-ma in the above comment,i have to remove voltageSensors.v from Modelica/Resources/Reference/Modelica/Electrical/PowerConverters/Examples/DCAC/PolyphaseTwoLevel/PolyphaseTwoLevel_RL/comparisonSignals.txt. I am confused should the result_csv also be changed? if yes, is it fine to just delete the columns from the result_csv or to generate a new set of result.
@henrikt-ma , @christiankral your suggestions would be really helpful.

@beutlich
Copy link
Member

beutlich commented Jul 6, 2023

I am confused should the result_csv also be changed? if yes, is it fine to just delete the columns from the result_csv or to generate a new set of result.

No, the results will be regenerated later when the new release is ready, usually for beta and rc releases.

@TManikantan
Copy link
Contributor

I am confused should the result_csv also be changed? if yes, is it fine to just delete the columns from the result_csv or to generate a new set of result.

No, the results will be regenerated later when the new release is ready, usually for beta and rc releases.

thank you for your response.

@casella
Copy link
Contributor

casella commented Jan 16, 2024

The discussion continued on the linked PR #4167.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example Issue only addresses example(s) L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters ref-result Issue addresses the reference results
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants