-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify spelling of controllers #3814
Comments
Personally, I dislike the term "PI element", as well as "proportional plus integral controller". |
I do not focus in the term element. To me this ticket is simply a matter of using the dash or not: PI-controller or PI controller. I somehow guess that the dash is not correct and I base my suspicion on Electropedia. I makes, however, sense to unify the spelling all over the MSL and add the correct spelling to Modelica.UsersGuide.Conventions.Terms.Electrical. |
So this issue needs input from a native English speaker please. |
@mtiller Could you possibly help here? |
I would write "PI controller" / "PID controller" |
Thanks @harmanpa, this makes sense. We shall omit the dash then. |
I have short listed the instances to which changes have to be made. Other than these i noticed that some documentation also carry the spelling "P-controller" . 1. Should i go ahead and make changes to above mentioned instances? If yes, Should i also change P-controller to P controller ? |
So I am in favor of applying these changes. |
What about
(Btw. do we need both "VfControllers"? They seem to be quite similar!) |
Yes we do, as they have different connectors. |
They also need different spelling. |
In
Modelica.Blocks.Continuous
the controllers are spelled, for example, the following way:In Electropedia the following spelling is used:
From my understanding it would thus also makes sense to omit the dash when using the term controller instead of element:
A comment from a native English speaking person is highly appreciated here. Possibly @mtiller or @harmanpa could comment here.
Once decided, this shall be documented in
Modelica.UsersGuide.Conventions.Terms.Electrical
.The text was updated successfully, but these errors were encountered: