Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit error in Modelica.Electrical.Batteries.Examples.BatteryDischargeCharge #4098

Closed
qlambert-pro opened this issue Mar 28, 2023 · 2 comments
Closed

Unit error in Modelica.Electrical.Batteries.Examples.BatteryDischargeCharge #4098

qlambert-pro opened this issue Mar 28, 2023 · 2 comments
Assignees
@christiankral
Labels
example Issue only addresses example(s) L: Electrical.Batteries Issue addresses Modelica.Electrical.Batteries
Milestone
MSL4.1.0

Comments

@qlambert-pro
Copy link
Contributor

qlambert-pro commented Mar 28, 2023 •
edited
Loading

The bindings given to cellData1.Ri and cellData2.Ri do not pass unit checking.

They are both given an expression expressed in "V" when they are expecting one expressed in "Ohm".
@qlambert-pro
Copy link
Contributor Author

Modelica.Electrical.Machines.Examples.DCMachines.DCPM_Drive suffers from a similar issue:

resistor.R expects a value expressed in "Ohm" but is given one expressed in "V"

@beutlich beutlich linked a pull request Mar 28, 2023 that will close this issue
Fix unit error in BatteryDischargeCharge #4101
Closed
@beutlich beutlich added example Issue only addresses example(s) L: Electrical.Batteries Issue addresses Modelica.Electrical.Batteries labels Jan 16, 2024
@beutlich beutlich added this to the MSL4.1.0 milestone Jan 16, 2024
@beutlich
Copy link
Member

Resolved by #4112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christiankral christiankral

Labels
example Issue only addresses example(s) L: Electrical.Batteries Issue addresses Modelica.Electrical.Batteries
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging a pull request may close this issue.

Fix unit error in BatteryDischargeCharge qlambert-pro/ModelicaStandardLibrary
3 participants
@qlambert-pro @christiankral @beutlich