Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move *Icon to dedicated icon packages #415

Closed
modelica-trac-importer opened this issue Jan 14, 2017 · 4 comments · Fixed by #3026
Closed

Move *Icon to dedicated icon packages #415

modelica-trac-importer opened this issue Jan 14, 2017 · 4 comments · Fixed by #3026
Assignees
Labels
L: Units Issue addresses Modelica.Units task General work that is not related to a bug or feature
Milestone

Comments

@modelica-trac-importer
Copy link

Reported by dietmarw on 21 Sep 2010 09:21 UTC
When looking at Modelica.SIunits.Conversions.* I was surprised to find among all those conversion functions also the ConversionIcon itself. In my opinion this should be moved to a proper place and renamed to:

Modelica.SIunits.Icons.Conversion

for the next release with conversion script.


Migrated-From: https://trac.modelica.org/Modelica/ticket/415

@modelica-trac-importer modelica-trac-importer added L: SIunits Issue addresses Modelica.SIunits task General work that is not related to a bug or feature labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 8 Jul 2011 12:04 UTC
The same goes for

Modelica.Blocks.Interfaces.*Icon

which should be moved to

Modelica.Blocks.Icons.*

@modelica-trac-importer modelica-trac-importer changed the title Move ConversionIcon to dedcated icon package? Move *Icon to dedicated icon packages Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 14 Sep 2011 14:58 UTC
I copied and updated the references for the Icons. At the same time I added an obsoleting warning (and icon) to the original copies to maintain backward compatibility.

This was done in:

There is still one icon I did not touch in Modelica.StateGraph but since the whole StateGraph sublibrary is obsolete I did not find it sensible to put updating effort of this nature into it.

This ticket should be kept open until the obsoleted classes are finally removed and a conversion script is provided.

@modelica-trac-importer modelica-trac-importer removed the L: SIunits Issue addresses Modelica.SIunits label Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 1 Aug 2015 21:36 UTC
Milestone renamed

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 1 Aug 2015 21:39 UTC
Milestone renamed

@modelica-trac-importer modelica-trac-importer added this to the MSL_next-MAJOR-version milestone Jan 14, 2017
@beutlich beutlich added the L: SIunits Issue addresses Modelica.SIunits label Jan 29, 2017
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Jul 6, 2019
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Jul 6, 2019
@beutlich beutlich assigned beutlich and unassigned MartinOtter Jul 6, 2019
beutlich added a commit that referenced this issue Jul 7, 2019
@beutlich beutlich changed the title Move *Icon to dedicated icon packages Move *Icon to dedicated icon packages Aug 21, 2019
@beutlich beutlich added L: Units Issue addresses Modelica.Units and removed L: SIunits Issue addresses Modelica.SIunits labels Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Units Issue addresses Modelica.Units task General work that is not related to a bug or feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants