Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect(p, p) in Modelica.Electrical.Analog.Examples.Utilities.SwitchedCapacitor? #4245

Closed
TongYuan-MC opened this issue Jan 6, 2024 · 2 comments · Fixed by #4261
Closed

Connect(p, p) in Modelica.Electrical.Analog.Examples.Utilities.SwitchedCapacitor? #4245

TongYuan-MC opened this issue Jan 6, 2024 · 2 comments · Fixed by #4261
Assignees
@AHaumer
Labels
example Issue only addresses example(s) L: Electrical.Analog Issue addresses Modelica.Electrical.Analog
Milestone
MSL4.1.0

Comments

@TongYuan-MC
Copy link

What is the purpose of connect(p, p)？Whether it is a valid connect-equation?
image
@AHaumer
Copy link
Contributor

AHaumer commented Jan 6, 2024

I suppose that is a bug.
If you release the mouse button during a connection too early, you get such a connection with zero length.
To me it seems that it doesn't affect the results, but we should remove it.

@HansOlsson
Copy link
Contributor

I suppose that is a bug. If you release the mouse button during a connection too early, you get such a connection with zero length. To me it seems that it doesn't affect the results, but we should remove it.

Agreed. Specifically it doesn't impact the result if there are other connection(s) to p, and two lines above we see another connection to p: connect(IdealCommutingSwitch1.n1, p).

@beutlich beutlich added L: Electrical.Analog Issue addresses Modelica.Electrical.Analog example Issue only addresses example(s) labels Jan 9, 2024
AHaumer added a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Jan 14, 2024
@AHaumer
resolves issue modelica#4245
7e495a2
@beutlich beutlich linked a pull request Jan 14, 2024 that will close this issue
Remove self-connect #4261
Merged
AHaumer added a commit that referenced this issue Jan 14, 2024
@AHaumer
Merge pull request #4261 from AHaumer/4245
9895491 
resolves issue #4245
@beutlich beutlich added this to the MSL4.1.0 milestone Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AHaumer AHaumer

Labels
example Issue only addresses example(s) L: Electrical.Analog Issue addresses Modelica.Electrical.Analog
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging a pull request may close this issue.

Remove self-connect AHaumer/ModelicaStandardLibrary
4 participants
@AHaumer @HansOlsson @beutlich @TongYuan-MC