Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSL v4.1.0-beta.1 feedback: Inconsistent experiment annotations in Modelica.Electrical.PowerConverters.Examples.DCDC.ExampleTemplates #4309

Closed
beutlich opened this issue Feb 10, 2024 · 2 comments · Fixed by #4318
Closed

MSL v4.1.0-beta.1 feedback: Inconsistent experiment annotations in Modelica.Electrical.PowerConverters.Examples.DCDC.ExampleTemplates #4309

beutlich opened this issue Feb 10, 2024 · 2 comments · Fixed by #4318
Assignees
@arunkumar-narasimhan @Harisankar-Allimangalath
Labels
example Issue only addresses example(s) L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters V: 4.1.0-dev Issue originates in MSL v4.1.0-dev (and is not present in earlier releases)
Milestone
MSL4.1.0

Comments

@beutlich
Copy link
Member

There are 3 example templates in Modelica.Electrical.PowerConverters.Examples.DCDC.ExampleTemplates, but only one of them (ChopperBuckBoost) has an experiment annoation.

ModelicaStandardLibrary/Modelica/Electrical/PowerConverters/Examples/DCDC/ExampleTemplates/ChopperBuckBoost.mo

Lines 112 to 115 in da5c5de

annotation (experiment(
StopTime=1,
Interval=1e-05,
Tolerance=1e-06), Documentation(info="<html>

I'd recommend to remove that experiment annotation on the partial models such that none of the three templates contains an experiment annotation.
@beutlich beutlich added L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters example Issue only addresses example(s) V: 4.1.0-dev Issue originates in MSL v4.1.0-dev (and is not present in earlier releases) labels Feb 10, 2024
@beutlich beutlich added this to the MSL4.1.0 milestone Feb 10, 2024
AHaumer added a commit to AHaumer/ModelicaStandardLibrary that referenced this issue Feb 13, 2024
@AHaumer
resolves modelica#4309
be4c454
@casella casella reopened this Feb 13, 2024
@casella
Copy link
Contributor

casella commented Feb 13, 2024

@Harisankar-Allimangalath @arunkumar-narasimhan, can you pleas port @AHaumer's commit to the maintenance branch and close this ticket. Thanks!

@beutlich beutlich removed this from the MSL4.1.0 milestone Feb 13, 2024
@beutlich beutlich added this to the MSL4.1.0 milestone Feb 13, 2024
Harisankar-Allimangalath pushed a commit to Harisankar-Allimangalath/ModelicaStandardLibrary_1 that referenced this issue Feb 15, 2024
@AHaumer @Harisankar-Allimangalath
resolves modelica#4309 (modelica#4310)
75e2380
@beutlich beutlich linked a pull request Feb 15, 2024 that will close this issue
Remove experiment annotation from Modelica.Electrical.PowerConverters.Examples.DCDC.ExampleTemplates.ChopperBuckBoost #4318
Merged
@beutlich
Copy link
Member Author

Resolved in both master and maint/4.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arunkumar-narasimhan arunkumar-narasimhan

@Harisankar-Allimangalath Harisankar-Allimangalath

Labels
example Issue only addresses example(s) L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters V: 4.1.0-dev Issue originates in MSL v4.1.0-dev (and is not present in earlier releases)
Projects
None yet
Milestone
MSL4.1.0
4 participants
@casella @beutlich @arunkumar-narasimhan @Harisankar-Allimangalath