Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-visible spliceFunction in Modelica/Fluid/Pipes.mo #596

Closed
modelica-trac-importer opened this issue Jan 14, 2017 · 3 comments
Closed
Assignees
Labels
bug Critical/severe issue duplicate Duplicate issue L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) P: high High priority issue
Milestone

Comments

@modelica-trac-importer
Copy link

Reported by stefanv on 29 Jul 2011 20:01 UTC
There's a call to spliceFunction in Modelica.Fluid.Pipes.BaseClasses.HeatTransfer.LocalPipeFlowHeatTransfer, and this function does not appear to be visible in that context.


Migrated-From: https://trac.modelica.org/Modelica/ticket/596

@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) P: high High priority issue labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by hubertus on 29 Jul 2011 21:37 UTC
That is true, and still the case in 3.2. There is a built-in such function in Dymola, which is why this is not noticed. I have fixed a number of occurences of this. A Modelica version of the function is in Modelica.Media.Air.MoistAir.spliceFunction, which is a pretty bad place if it is used at several places in Modelica.Fluid. Anyways, the function call should be to Modelica.Media.Air.MoistAir.spliceFunction().

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 29 Jul 2011 21:59 UTC
As a short-term fix for 3.2 and the following 3.x versions I would suggest simply changing the call.

For a long-term solution (i.e., when conversion scripts are available) we should move spliceFunction() and spliceFunction_der() somewhere suitable under Modelica.Math (and add some proper documentation to it ;-)).

@modelica-trac-importer modelica-trac-importer changed the title Non-visible spliceFunction in Modelica3.1/Fluid/Pipes.mo Non-visible spliceFunction in Modelica/Fluid/Pipes.mo Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 2 Aug 2012 12:57 UTC
This was already fixed in 82f8c79 (see ticket #488). Also for now I don't see the need to generalise that function as it is (so far) only used once in Fluid and else within Media.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue duplicate Duplicate issue L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) P: high High priority issue
Projects
None yet
Development

No branches or pull requests

2 participants