Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "IdealCommutingSwitch" to "IdealTwoWaySwitch" #778

Closed
modelica-trac-importer opened this issue Jan 14, 2017 · 13 comments · Fixed by #3135
Closed

Rename "IdealCommutingSwitch" to "IdealTwoWaySwitch" #778

modelica-trac-importer opened this issue Jan 14, 2017 · 13 comments · Fixed by #3135
Assignees
@dietmarw
Labels
L: Electrical.Analog Issue addresses Modelica.Electrical.Analog task General work that is not related to a bug or feature
Milestone
MSL4.0.0

Comments

@modelica-trac-importer
Copy link

Reported by leo.gall on 17 Jul 2012 17:17 UTC
The name of Modelica.Electrical.Analog.Ideal.IdealCommutingSwitch seems to use the wrong word:
"commute" (in German: pendeln/umwandeln)
instead of
"commutate" (in German: kommutieren/umschalten).

Any native speakers here who could comment on this?

Renaming would have to wait for a conversion script, therefore I set milestone to MSL 4.0.

Migrated-From: https://trac.modelica.org/Modelica/ticket/778
@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: Electrical.Analog Issue addresses Modelica.Electrical.Analog labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Modified by otter on 18 Jul 2013 12:09 UTC

@modelica-trac-importer
Copy link
Author

Changelog removed by otter on 18 Jul 2013 12:09 UTC

@modelica-trac-importer modelica-trac-importer added P: lowest Lowest priority issue enhancement New feature or enhancement and removed bug Critical/severe issue labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 1 Aug 2015 21:36 UTC
Milestone renamed

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 1 Aug 2015 21:39 UTC
Milestone renamed

@modelica-trac-importer modelica-trac-importer added this to the MSL_next-MAJOR-version milestone Jan 14, 2017
@beutlich
Copy link
Member

@ceraolo What is IEC's wording here?

@ceraolo
Copy link

ceraolo commented Jan 30, 2017

there is not much on this in the IEV.

After some research there I would conclude that better than "Commuting switch" it is "SelectorSwitch:
http://dom2.iec.ch/iev/iev.nsf/display?openform&ievref=151-12-24

And better than "IntermediateSwitch" is "ReversingSwitch":
http://dom2.iec.ch/iev/iev.nsf/display?openform&ievref=151-12-25

@beutlich
Copy link
Member

beutlich commented Jul 15, 2019 •
edited

@AHaumer @christiankral @dietmarw Should we do the renaming as proposed by @ceraolo?

  • IdealCommutingSwitch -> IdealSelectorSwitch
  • ControlledIdealCommutingSwitch -> ControlledIdealSelectorSwitch
  • IdealIntermediateSwitch -> IdealReversingSwitch
  • ControlledIdealIntermediateSwitch -> ControlledIdealReversingSwitch

@beutlich beutlich added discussion Discussion issue that it not necessarily related to a concrete bug or feature task General work that is not related to a bug or feature and removed enhancement New feature or enhancement labels Jul 15, 2019
@AHaumer
Copy link
Contributor

AHaumer commented Jul 15, 2019

To be honest: "Commuting" is wrong.
to commute = German "pendeln", ie. travel from home to work and back.
commutate = German "wenden, umpolen" - this is used in a DC machine,
I'd propose: Commuting -> TwoWay or ChangeOver (German "Wechselschalter")
Intermediate is correct (German "Kreuzschalter"),
The alternative TwoWayDoublePoleRevesing is clumsy.

@beutlich
Copy link
Member

Any native speakers here who could comment on this?

@harmanpa Can you please help out on this language issue? Thanks.

@christiankral
Copy link
Contributor

christiankral commented Jul 15, 2019 •
edited

  • SelectorSwitch seems to cover the type of switch we are taking about, but to me the affected model is a special selector switch with just two switching positions. Selector switch sounds to me like having more than two switching positions. I am in favor of this proposal if some other native speakers agree to it.
  • ReversalSwitch seems the right term to me.

@AHaumer
Copy link
Contributor

AHaumer commented Jul 15, 2019

I have the same opinion as @christiankral regarding "Selector", but I don't understand "Reversal" = "umkehren"? I did look up in "Langenscheidt", finding the terms mentiones by my previous post.
I would keep "Intermediate" = "Kreuzschalter", but change "Commuting" to "TwoWay" = "Wechselschalter",

@harmanpa
Copy link
Member

harmanpa commented Oct 6, 2019

I'd favour the suggestion from @AHaumer of TwoWaySwitch, it is clear and easier to spell than Commutating!

@beutlich
Copy link
Member

beutlich commented Oct 6, 2019

So it will be:

  • IdealCommutingSwitch -> IdealTwoWaySwitch
  • ControlledIdealCommutingSwitch -> ControlledTwoWaySwitch
  • IdealIntermediateSwitch: keep as is
  • ControlledIdealIntermediateSwitch: keep as is

dietmarw added a commit to dietmarw/ModelicaStandardLibrary that referenced this issue Oct 7, 2019
@dietmarw
Fixes modelica#778 by renaming "Commuting" to "TwoWay"
6348e32 
Also includes conversion script and test.
Note: The ticket suggests to replace "IdealCommuting" with  "TwoWay" instead of "IdealTwoWay" which is probably an oversight and would introduce inconsistency.
@beutlich beutlich assigned dietmarw and unassigned christophclauss Oct 7, 2019
@dietmarw dietmarw mentioned this issue Oct 8, 2019
Merged
beutlich added a commit that referenced this issue Oct 9, 2019
@beutlich
Merge pull request #3135 from dietmarw/t778-renameSwitch
4171ae2 
Fix #778 by renaming "Commuting" to "TwoWay"
@beutlich beutlich removed the discussion Discussion issue that it not necessarily related to a concrete bug or feature label Oct 9, 2019
@beutlich beutlich changed the title Rename "IdealCommutingSwitch" to "IdealCommutatingSwitch"? Rename "IdealCommutingSwitch" to "IdealCommutatingSwitch" Oct 9, 2019
@beutlich beutlich removed the P: lowest Lowest priority issue label Oct 9, 2019
@perost perost mentioned this issue Oct 15, 2019
Merged
@beutlich beutlich changed the title Rename "IdealCommutingSwitch" to "IdealCommutatingSwitch" Rename "IdealCommutingSwitch" to "IdealTwoWaySwitch" Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dietmarw dietmarw

Labels
L: Electrical.Analog Issue addresses Modelica.Electrical.Analog task General work that is not related to a bug or feature
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging a pull request may close this issue.

Fix #778 by renaming "Commuting" to "TwoWay" dietmarw/ModelicaStandardLibrary
10 participants
@dietmarw @harmanpa @christiankral @AHaumer @ceraolo @beutlich @kristinmajetta @modelica-trac-importer @ECClauss @christophclauss