Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move LogFrequencySweep from ComplexBlocks to Blocks #2158

Closed
wants to merge 1 commit into from
Closed

Move LogFrequencySweep from ComplexBlocks to Blocks #2158

wants to merge 1 commit into from

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Feb 7, 2017

refs #2157: Move LogFrequencySweep from ComplexBlocks to Blocks

@beutlich beutlich added L: Blocks Issue addresses Modelica.Blocks L: Complex* Issue addresses Complex, Modelica.ComplexBlocks or Modelica.ComplexMath labels Feb 7, 2017
@beutlich beutlich added this to the MSL_next-MAJOR-version milestone Feb 7, 2017
@beutlich beutlich requested review from dietmarw and removed request for dietmarw February 7, 2017 07:57
dietmarw
dietmarw reviewed Feb 7, 2017
View reviewed changes
Copy link
Member

@dietmarw dietmarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I'm not the library officer, I can't really comment.

@tbeu
Copy link
Contributor

tbeu commented Feb 7, 2017

This only was a test of the GitHub Reviewer feature.

@tbeu tbeu assigned tbeu and unassigned tbeu Feb 7, 2017
@beutlich beutlich requested a review from AHaumer February 7, 2017 09:26
@beutlich beutlich self-assigned this Feb 7, 2017
hubertus65
hubertus65 approved these changes Jan 21, 2018
View reviewed changes
Copy link
Member

@hubertus65 hubertus65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a correct change, even though I am not the library officer. And includes update script

@MartinOtter
Copy link
Member

This is a non-backwards compatible change (moving a block from one library to another one). This means that existing models using this block will no longer work. As long as we have not yet decided that conversion scripts can be used, we should not perform such changes (a pre-requisite is that the tool vendors support the conversion annotations introduced in Modelica 3.4).

@beutlich
Copy link
Member Author

This is a non-backwards compatible change (moving a block from one library to another one).

For that reason, the milestone is set to MSL_next-MAJOR-version, which is defined as the next (not yet specified) major version which is non-backward compatible and (might) need a conversion script.

@beutlich
Copy link
Member Author

Clsoing after @AHaumer's #2157 (comment).

@beutlich beutlich closed this Jan 22, 2018
@beutlich beutlich modified the milestones: MSL_next-MAJOR-version, never Jan 22, 2018
@beutlich beutlich deleted the issue-2157 branch January 22, 2018 08:57
@christiankral christiankral mentioned this pull request Jan 24, 2018
Closed
@beutlich beutlich removed the request for review from AHaumer June 15, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dietmarw dietmarw dietmarw left review comments

@hubertus65 hubertus65 hubertus65 approved these changes

Assignees

@beutlich beutlich

Labels
L: Blocks Issue addresses Modelica.Blocks L: Complex* Issue addresses Complex, Modelica.ComplexBlocks or Modelica.ComplexMath
Projects
None yet
Milestone
never
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@beutlich @tbeu @MartinOtter @dietmarw @hubertus65