Fix icon for Electrical.Digital #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, there seems to be one line in there that I am unsure if it belongs or not. I'll the icon and one without the line I am uncertain about. As it looks in the PR: What it should look like? |
|
I think the extra line might be meant to represent a digital signal. (Although it is more like a ternary signal in that case.) |
|
Point to @MartinOtter instead of otter. |
beutlich
added
the
L: Electrical.Digital
|
Please remove that ternary signal line added by bf5ac67 and reveal the block icon. |
Reverts the changes in bf5ac67 and instead fixes the error that caused the old icon to not be displayed.
|
So the second image, then? Basically reverting bf5ac67 and instead of adding the signal fixing the error in the icon. |
|
LGTM. |
|
Also cherry-picked in maint/3.2.2 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current icon has the lines in the wrong part of the annotation.
The error was found when making OMEdit report failure to interpret icon annotations. The change was tested in OMEdit and looks reasonable (please review; I can add it to maint/3.2.2 once accepted into the master). The source of the error seems to be bf5ac67 (@otter), which says it added an icon for Digital (but there seems to have already been an icon there).