ClarifyBreakable in ModelicaReference #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dietmarw
requested changes
Nov 1, 2017
ModelicaReference/package.mo
Outdated
| Defines a non-breakable branch from the overdetermined type or record instance <code>R</code> in connector instance <code>A</code> to the corresponding overdetermined type or record instance <code>R</code> in connector instance <code>B</code> for a virtual connection graph. | ||
| Defines a branch from the overdetermined type or record instance <code>R</code> in connector instance <code>A</code> to the corresponding overdetermined type or record instance <code>R</code> in connector instance <code>B</code> for a virtual connection graph. | ||
| These branches are required to be part of the spanning-tree for the virtual connection graph (they do not directly generate equations, but should be combined with equations coupling A.R to B.R), | ||
| whereas connect-statements are optional for the spanning-tree (and generate different equations depending on whether they are part of the spanning-tree or not). |
There was a problem hiding this comment.
A.R to B.R should be changed to <code>A.R</code> to <code>B.R</code>
There was a problem hiding this comment.
Updated as indicated.
dietmarw
approved these changes
Nov 1, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove "breakable branch" from connect (since it is confusing).
As decided in https://trac.modelica.org/Modelica/ticket/2201
Also try to explain Connections.branch in a clearer way: both that it is required to be part of spanning-tree, whereas connect is optional for the spanning-tree; and also that Connections.branch does not generate equation - but assumes that equations are present; whereas connect generates equations.