Fixing typos and unwanted changes in several packages #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dietmarw
approved these changes
May 4, 2018
beutlich
reviewed
May 4, 2018
| @@ -2495,7 +2495,7 @@ i.e., it defines a fixed temperature as a boundary condition. | |||
| Text( | |||
| extent={{-150,150},{150,110}}, | |||
| textString="%name", | |||
| lineCdefaultComponentName="temperatureSource",olor={0,0,255}), | |||
beutlich
added a commit
to GallLeo/ModelicaStandardLibrary
that referenced
this pull request
May 4, 2018
…ontrolledDCDrives.SpeedControlledDCPM.
….PrescribedTemperature. This removes defaultComponentName, which didn't have any effect and couldn't be found in Celsius.PrescribedTemperature.
|
@christiankral It would be more fortunate if you first check the open pull requests (like this one) and afterwards rearrange the models (like done in fa63e56) to avoid merge conflicts. Anyway, I rebased the 5 commits on fa63e56 and resolved the merge conflict. |
|
@beutlich Sorry for messing up some pull request. If will check those first in the future, before making changes. |
christiankral
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes typos in various sub-libraries and one bug in the annotation of Modelica.Thermal.HeatTransfer.Fahrenheit.PrescribedTemperature.
This has been done semi-automatic. I tried hard to not introduce unwanted changes. Please review changes.