Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2719 modified Eucken R in J/kg.K #2734

Merged
merged 2 commits into from Oct 15, 2018

Conversation

thorade
Copy link
Contributor

@thorade thorade commented Oct 11, 2018

This closes #2719.

data.R = Modelica.Constant.R/data.MM

@finback-at: This should be identical to the solution you suggested, could you verify it gives the same results?

@beutlich beutlich added bug Critical/severe issue L: Media Issue addresses Modelica.Media labels Oct 11, 2018
@beutlich beutlich added this to the MSL3.2.3 milestone Oct 11, 2018
@beutlich beutlich changed the title Issue2719 eucken r Issue2719 Eucken R in J/kg.K Oct 11, 2018
@beutlich beutlich changed the title Issue2719 Eucken R in J/kg.K Issue2719 modified Eucken R in J/kg.K Oct 11, 2018
@finback-at
Copy link

Thank you for this change!
Cp*data.MM/Modelica.Constants.R and Cp/data.R give same results.
Both data.MM and data.R are provided from Media.IdealGases.Common.SingleGasesData.
Consistencies of those depend on this data table.
I checked it and the calculation results of thermal conductivity using these 2 form of equations for
the cases of Ar, CH4, CO, CO2, H2, N2, H2O, O2, He and C3H8.
Off course, the results are same.
And those shows better agreements with NIST data than previous.
I think it's alright!

Copy link

@finback-at finback-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first suggested equation (#2719) is using Cp*dataMM/Modelica.Constants.R,
and this correction using Cp/data.R. In principle, these are identical.
Difference between them depend on SingleGasesData (Nasa Glenn data table).
I checked for the cases of Ar, CH4, CO, CO2, H2, N2, H2O, O2, He, C3H8.
The order of differences are about 1e-6 - 1e-5.
This correction gives better agreements of thermal conductivity with the data of
NIST chemistry webbook for all cases.

@beutlich beutlich removed the request for review from casella October 15, 2018 05:39
@beutlich beutlich merged commit 317b113 into modelica:master Oct 15, 2018
@beutlich beutlich changed the title Issue2719 modified Eucken R in J/kg.K Issue #2719 modified Eucken R in J/kg.K Oct 15, 2018
@beutlich beutlich assigned beutlich and unassigned hubertus65 Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: Media Issue addresses Modelica.Media
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in the modified Eucken method of Modelica.Media.IdealGases.Common.Functions.thermalConductivityEstimate
4 participants