Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2401 by correcting the spelling of Density #2754

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

dietmarw
Copy link
Member

@dietmarw dietmarw commented Oct 26, 2018

fix #2401

@dietmarw dietmarw added this to the MSL_next-MAJOR-version milestone Oct 26, 2018
@beutlich beutlich added the L: SIunits Issue addresses Modelica.SIunits label Oct 26, 2018
@dietmarw
Copy link
Member Author

dietmarw commented Jan 24, 2019

I checked and the misspelled unit is not used inside the MSL. However I wonder if the current conversion script rules allow for a fix in user models.

I was thinking of convertModifiers here but it seems that one needs to specify a class explicitly. Otherwise I could think that a conversion script entry like

convertModifiers("*",{"quantity=TotalNeutronSourceDesity"}, 
                     {"quantity=TotalNeutronSourceDensity"})

@HansOlsson Do I see that correctly that the current set of conversion script commands does not allow for such a correction?

@HansOlsson
Copy link
Contributor

I checked and the misspelled unit is not used inside the MSL. However I wonder if the current conversion script rules allow for a fix in user models.

I don't think so, but I don't think it is needed either:

As I understand it the type-name is correctly spelt, but its quantity attribute is misspelt. If the type-name is used in a user-model that will just become correct without the need for a conversion script.

Having conversion scripts for general misspellings of attributes in user models seems a bit odd, and wasn't considered when adding this.

@dietmarw
Copy link
Member Author

OK that's good enough for me then.

@dietmarw dietmarw self-assigned this Jan 24, 2019
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dietmarw dietmarw merged commit 4c13af3 into modelica:master Jan 24, 2019
@dietmarw dietmarw deleted the t2401_SpellingOfDensity branch January 24, 2019 14:57
@beutlich beutlich added L: Units Issue addresses Modelica.Units and removed L: SIunits Issue addresses Modelica.SIunits labels Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Units Issue addresses Modelica.Units
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo: Spelling of Density
4 participants