-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of values for Modelica.Constants according to codata2017 #2774
Conversation
…/Modelica into HansOlsson-codata2017
Based on: https://www.bipm.org/utils/en/pdf/CGPM/Draft-Resolution-A-EN.pdf (Which changes SI-system on 2019-05-20, and will be discussed today 2018-11-16.) Note that G is still determined experimentally, and I don't know if that was changed in codata 2017 (doesn't seem that way; since G is really tricky to measure and unrelated to the other constants.) Closes modelica#2207
Should we also set the previous value in the comment when it was changed? |
Hmm... I see two possibilities: add date when changed, or just remove previous values. Considering that it will not change in the future the latter seems better. |
OK. |
Remove previous values.
# Conflicts: # Modelica/Constants.mo
…/Modelica into HansOlsson-codata2017
Hmm.. It could stay, or could reference https://www.bipm.org/en/CGPM/db/26/1/ - I'll update to the latter; as it seems more future-proof. |
# Conflicts: # Modelica/Constants.mo
@MartinOtter I resolved the merge conflict. Can you please update your review as library officer of Modelica.Constants. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HansOlsson The link https://www.bipm.org/en/CGPM/db/26/1/ seems to be no longer valid.
I just tested it with 3 browsers without any issue. |
Right. Can no longer reproduce the error. |
Unfortunately, there was no feeback by the Library Officer within 2 weeks. |
What is the meaning of the following comment:
My understanding is that absolute zero is still precisely defined (0K / -273.15 C)... |
Ah, you are right - I must have misread or read a previous version - will update. Obviously absolute zero is still 0 K. |
Update of values for Modelica.Constants
Closes #2207
The values are already more correct that previous ones, and from 2019-05-20 they will be likely be final; except for G and T_zero (on the other hand the triple point for water (suitably defined) will be 273.16K).
Watch live: https://www.youtube.com/watch?v=qA67T7FPBME