Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of values for Modelica.Constants according to codata2017 #2774

Merged
merged 15 commits into from
May 28, 2019

Conversation

HansOlsson
Copy link
Contributor

Update of values for Modelica.Constants
Closes #2207
The values are already more correct that previous ones, and from 2019-05-20 they will be likely be final; except for G and T_zero (on the other hand the triple point for water (suitably defined) will be 273.16K).

Watch live: https://www.youtube.com/watch?v=qA67T7FPBME

HansOlsson and others added 7 commits March 8, 2017 16:46
Based on: https://www.bipm.org/utils/en/pdf/CGPM/Draft-Resolution-A-EN.pdf
(Which changes SI-system on 2019-05-20, and will be discussed today 2018-11-16.)

Note that G is still determined experimentally, and I don't know if that was changed in codata 2017 (doesn't seem that way; since G is really tricky to measure and unrelated to the other constants.)
Closes modelica#2207
@beutlich
Copy link
Member

beutlich commented Nov 16, 2018

Should we also set the previous value in the comment when it was changed?

@beutlich beutlich added the L: Constants Issue addresses Modelica.Constants label Nov 16, 2018
@beutlich beutlich self-assigned this Nov 16, 2018
@HansOlsson
Copy link
Contributor Author

Should we also the previous value in the comment when it was changed?

Hmm... I see two possibilities: add date when changed, or just remove previous values. Considering that it will not change in the future the latter seems better.

@beutlich
Copy link
Member

the latter seems better.

OK.

Remove previous values.
@beutlich beutlich changed the title Hans olsson codata2017 Update of values for Modelica.Constants according to codata2017 Nov 16, 2018
@beutlich beutlich added this to the MSL_next-MAJOR-version milestone Nov 16, 2018
MartinOtter
MartinOtter previously approved these changes Dec 11, 2018
Modelica/Constants.mo Outdated Show resolved Hide resolved
HansOlsson and others added 2 commits March 25, 2019 10:25
Modelica/Constants.mo Outdated Show resolved Hide resolved
@HansOlsson
Copy link
Contributor Author

Hmm.. It could stay, or could reference https://www.bipm.org/en/CGPM/db/26/1/ - I'll update to the latter; as it seems more future-proof.

@beutlich beutlich added the enhancement New feature or enhancement label Mar 29, 2019
# Conflicts:
#	Modelica/Constants.mo
@beutlich
Copy link
Member

beutlich commented May 6, 2019

@MartinOtter I resolved the merge conflict. Can you please update your review as library officer of Modelica.Constants. Thanks.

Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HansOlsson The link https://www.bipm.org/en/CGPM/db/26/1/ seems to be no longer valid.

@HansOlsson
Copy link
Contributor Author

HansOlsson commented May 21, 2019

@HansOlsson The link https://www.bipm.org/en/CGPM/db/26/1/ seems to be no longer valid.

I just tested it with 3 browsers without any issue.

@beutlich beutlich requested a review from MartinOtter May 21, 2019 18:07
@beutlich
Copy link
Member

@HansOlsson The link https://www.bipm.org/en/CGPM/db/26/1/ seems to be no longer valid.

I just tested it with 3 browsers without any issue.

Right. Can no longer reproduce the error.

@beutlich
Copy link
Member

@MartinOtter I resolved the merge conflict. Can you please update your review as library officer of Modelica.Constants. Thanks.

Unfortunately, there was no feeback by the Library Officer within 2 weeks.

@beutlich beutlich merged commit 5cb22fe into modelica:master May 28, 2019
@mestinso
Copy link
Collaborator

mestinso commented Jun 1, 2019

What is the meaning of the following comment:

Note that T_zero is not exact, instead the triple point of water is 273.16 K.

My understanding is that absolute zero is still precisely defined (0K / -273.15 C)...
Meanwhile, triple point of water is now no longer precise: 273.16000 K +- 0.00010 K
where the 0.00010 figure comes from 273.16*3.7e-7 taken from here: https://www.bipm.org/en/CGPM/db/26/1/

@HansOlsson
Copy link
Contributor Author

My understanding is that absolute zero is still precisely defined (0K / -273.15 C)...
Meanwhile, triple point of water is now no longer precise: 273.16000 K +- 0.00010 K

Ah, you are right - I must have misread or read a previous version - will update.

Obviously absolute zero is still 0 K.
And Kelvin is determined from a fixed value of Boltzman constant, and degree Celsius just differs by 273.15 K.
Thus the triple point of water (about 273.16 K, 0.01 degree C) and "normal" freezing point (about 273.15 K, 0 degree C) both need to be experimentally determined.

@HansOlsson HansOlsson deleted the HansOlsson-codata2017 branch April 8, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement L: Constants Issue addresses Modelica.Constants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing constants (2018 edition)!
4 participants