Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use same variable names in definition and declaration #2844

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Use same variable names in definition and declaration #2844

merged 1 commit into from
Mar 18, 2019

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Mar 2, 2019

See #2842.

@beutlich beutlich added the L: C-Sources Issue addresses Modelica/Resources/C-Sources label Mar 2, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Mar 2, 2019
@beutlich beutlich self-assigned this Mar 2, 2019
@beutlich beutlich added the V: 3.2.1 Issue originates in MSL v3.2.1 (and is not present in earlier releases) label Mar 2, 2019
HansOlsson
HansOlsson approved these changes Mar 3, 2019
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I noticed that there is still "nCols" in the data-structure, but changing a data-structure is slightly more risky so would need to be considered more.

@beutlich beutlich merged commit ec70d1f into modelica:master Mar 18, 2019
@beutlich beutlich deleted the fix-argument-name branch March 18, 2019 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjoelund sjoelund sjoelund approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@beutlich beutlich

Labels
L: C-Sources Issue addresses Modelica/Resources/C-Sources V: 3.2.1 Issue originates in MSL v3.2.1 (and is not present in earlier releases)
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@beutlich @sjoelund @HansOlsson