Add more spelling terms #2854
Merged
Add more spelling terms #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dietmarw
previously approved these changes
Mar 11, 2019
… same entry in electrical terms
tobolar
requested changes
Mar 12, 2019
There was a problem hiding this comment.
According to table format rules, there has to be a caption as well, see Modelica.UsersGuide.Conventions.Documentation.Format.Tables, rule 3:
Each table must have a table caption.
Actually, there is also a rule saying Table headers and entries start with capital letters. But I wouldn't insist on this. We shall rahter discuss whether to restrict this rule to table headers only.
beutlich
previously approved these changes
Mar 22, 2019
beutlich
added
L: UsersGuide
dietmarw
previously approved these changes
Mar 25, 2019
|
@tobolar Please review again (as merging currently is blocked). |
|
Actually, I'm still missing tables' captions. |
Unify indentation of tables
introduced in 00b58db
beutlich
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2694