-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop deprecated LAPACK apis #2857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reporting and fixing this. We are in the preparations for new major MSL (where we are actually allowed to break backwards-compatibility).
As these functions are not used within the MSL it seems sufficient. However, instead of removing these four functions, we require to
- move them to a (to be created) package ObsoleteModelica4.Math.Matrices.LAPACK,
- provide conversion scripts for automatic updating of user libraries (by either using the moved functions or the replacement functions dgelsy, dggev, dgeqp3)
- test models to test the conversion.
Saying this, we missed to mark them as obsolete now, such that users of the latest MSL v3.2.3 are aware of the deprecated functions and the change does not come as unexpected surprise. Not sure, how strict we should be here.
I dont know how to create packages, can you provide details ? |
dgelsx, dgegv, dgeqpf are deprecated since lapack 3.1.1 (2007), remove them
5269edf
to
bc52f48
Compare
@HansOlsson @MartinOtter This PR is now ready for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The work-areas for dgeqp3 does not seem ideal since:
- It is the minimum possible; which will not utilize the level-3 block algorithm in a good way. Would it be possible to have lwork as an optional input (with suitable default)?
- The work-area length is duplicated. If we cannot use work[lwork] would it be possible to not have "lwork" as a variable and instead replace lwork in the argument list by size(work,1)?
Hm, could do so. What would be a suitable default for lwork then? Leave it as
Many LAPACK functions do so (for example dgesvd_sigma) and I just adopted this style of implementation. |
Yes.
You're right. That should likely be improved for more functions. |
Note, that a an Integer variable lwork is mapped to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok.
75645e4
to
db05046
Compare
51e4f65
to
81f6ab1
Compare
dgelsx, dgegv, dgeqpf are deprecated since lapack 3.1.1 (2007), remove them