Clarify simplifying assumptions for Modelica.Media.Incompressible #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansOlsson
added
L: Media
thorade
reviewed
Mar 21, 2019
thorade
approved these changes
Mar 21, 2019
beutlich
changed the title
hubertus65
approved these changes
Apr 17, 2019
casella
approved these changes
May 17, 2019
There was a problem hiding this comment.
As noted in PR #2856, the statement that h and u cannot be both independent is not true in general (specifically for ideal gases). However, it is definitely true for incompressible media, which is the relevant scope here, so this is fine for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to improve text based on discussion in #2856, so that it is more correct - without being excessively long.
Since the flags influence both enthalpy and inner energy it makes sense to mention both of them. I believe that the text parenthesis is correct, but I am no expert.