Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename mue to mu #2864

Merged
merged 6 commits into from
Apr 4, 2019
Merged

Rename mue to mu #2864

merged 6 commits into from
Apr 4, 2019

Conversation

tobolar
Copy link
Contributor

@tobolar tobolar commented Mar 26, 2019

close #194

@tobolar tobolar changed the title Rename 'mue' to 'mu' in Mechanics Rename 'mue' to 'mu' Mar 26, 2019
@tobolar @beutlich
Change 'mue' to 'mu' in Mechanics
451b1dc 
close #194

# Conflicts:
#	Modelica/Resources/Scripts/Conversion/ConvertModelica_from_3.2.3_to_4.0.0.mos
@tobolar @beutlich
Add conversion test units
e6943ab 
# Conflicts:
#	ModelicaTestConversion4.mo
@tobolar @beutlich
Rename 'mue' to 'mu' in Constants
89218d4
@beutlich beutlich added L: Constants Issue addresses Modelica.Constants L: Magnetic.FluxTubes Issue addresses Modelica.Magnetic.FluxTubes L: Magnetic.QuasiStatic Issue addresses Modelica.Magnetic.QuasiStatic L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational labels Mar 26, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Mar 26, 2019
@beutlich beutlich added the enhancement New feature or enhancement label Mar 26, 2019
@christiankral
Copy link
Contributor

Shouldn't there also be a conversion command for the constant Modelica.Constants.mu_0 itself, or did I overlook it.

@tobolar
Copy link
Contributor Author

tobolar commented Mar 27, 2019

@christiankral Fixed, many thanks.

dietmarw
dietmarw reviewed Mar 27, 2019
View reviewed changes
Copy link
Member

@dietmarw dietmarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about a test model for that conversion?

@tobolar
Copy link
Contributor Author

tobolar commented Mar 27, 2019 •
edited
Loading

Shall be covered with ModelicaTestConversion4 (ModelicaTestConversion4.Constants.Issue194). Or do you miss something particular?

@beutlich beutlich changed the title Rename 'mue' to 'mu' Rename mue to mu Mar 29, 2019
@beutlich beutlich removed L: Constants Issue addresses Modelica.Constants L: Magnetic.FluxTubes Issue addresses Modelica.Magnetic.FluxTubes L: Magnetic.QuasiStatic Issue addresses Modelica.Magnetic.QuasiStatic L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational L: Mechanics.Translational Issue addresses Modelica.Mechanics.Translational labels Mar 29, 2019
@beutlich beutlich self-assigned this Mar 29, 2019
dietmarw
dietmarw approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@dietmarw dietmarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine then.

christiankral
christiankral approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks reasonable to me.

@beutlich beutlich removed the request for review from MartinOtter April 4, 2019 13:33
@beutlich beutlich merged commit 74a3bdd into modelica:master Apr 4, 2019
@tobolar tobolar deleted the issue194_mue branch April 4, 2019 15:17
@beutlich beutlich added task General work that is not related to a bug or feature and removed enhancement New feature or enhancement labels May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dietmarw dietmarw dietmarw approved these changes

@christiankral christiankral christiankral approved these changes

@beutlich beutlich beutlich approved these changes

Assignees

@beutlich beutlich

Labels
task General work that is not related to a bug or feature
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

Change Greek parameter name 'mue' to 'mu', 'nue' to 'nu' and 'lamda' to 'lambda'
4 participants
@tobolar @christiankral @dietmarw @beutlich