Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of Modelica.SIunits.Height in Modelica.Fluid #2876

Merged
merged 3 commits into from
May 17, 2019
Merged

Fix usage of Modelica.SIunits.Height in Modelica.Fluid #2876

merged 3 commits into from
May 17, 2019

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Apr 4, 2019

Backport fix of #2834 to maint/3.2.3 branch

beutlich and others added 2 commits April 4, 2019 18:59
@beutlich
refs modelica#2639: Fix usage of SIunits.Height
d3049d2
@casella @beutlich
Further fixes to PartialPump
77c9119 
Changed Length into Position (more appropriate), and improved the simplified expression to use an approximation of the tangent to the pump curve around the initialization point
@beutlich beutlich added bug Critical/severe issue L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) labels Apr 4, 2019
@beutlich beutlich added this to the MSL3.2.3+maint milestone Apr 4, 2019
@beutlich beutlich self-assigned this Apr 4, 2019
@beutlich beutlich mentioned this pull request Apr 4, 2019
Merged
HansOlsson
HansOlsson approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but in the release notes we should also include that the initialization was improved for the pump - and it was not only the unit-change.

casella
casella approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (just a backport of previously approved stuff)

@casella casella merged commit 2556186 into modelica:maint/3.2.3 May 17, 2019
@beutlich beutlich assigned casella and unassigned beutlich May 17, 2019
@beutlich beutlich deleted the fix-height-maint branch May 17, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casella casella casella approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@casella casella

Labels
bug Critical/severe issue L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)
Projects
None yet
Milestone
MSL3.2.3+maint
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@beutlich @casella @HansOlsson