Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename table blocks CombiTable1D to CombiTable1Dv and CombiTable2D to CombiTable2Ds #2884

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Apr 6, 2019

Please note that I also changed the order of the blocks, which explains the non-intuitive diff.

grafik

Close #2441.

@beutlich beutlich added the L: Blocks Issue addresses Modelica.Blocks label Apr 6, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Apr 6, 2019
@beutlich beutlich self-assigned this Apr 6, 2019
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
The diff is a mess - but the new order that caused it is better.

* Rename CombiTable1D to CombiTable1Dv
* Rename CombiTable2D to CombiTable2Ds
@beutlich beutlich merged commit 2e5096a into modelica:master Apr 30, 2019
@beutlich beutlich deleted the rename-table-blocks branch April 30, 2019 18:53
beutlich added a commit that referenced this pull request Jan 20, 2020
beutlich added a commit that referenced this pull request Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Blocks Issue addresses Modelica.Blocks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent names of table blocks CombiTable1D/CombiTable2D
3 participants