Remove legacy initialization of Modelica.Blocks.Continuous.{PID, LimPID}

[beutlich]

@HansOlsson This is what I tried to remove the now invalid modifier Init.DoNotUse_InitialIntegratorState. But no matter what I did, it did not work out, since enumeration simplification did not run when converting ModelicaTestConversion4.Blocks.Issue2892.

convertModifiers({"Modelica.Blocks.Continuous.LimPID",
                  "Modelica.Blocks.Continuous.PID"},
                  {"initType"}, {"initType=if Integer(%initType%) < 5 then %initType% else Modelica.Blocks.Types.Init.NoInit"}, true);

Do you have any hint how to do it?

Closes #2892.

[beutlich]

@HansOlsson Friendly reminder.

[HansOlsson]

@HansOlsson Friendly reminder.

I haven't forgotten it. But I think it will take some time to look at and I haven't had that time.

[HansOlsson]

@HansOlsson This is what I tried to remove the now invalid modifier Init.DoNotUse_InitialIntegratorState. But no matter what I did, it did not work out, since enumeration simplification did not run when converting ModelicaTestConversion4.Blocks.Issue2892.
convertModifiers({"Modelica.Blocks.Continuous.LimPID",
"Modelica.Blocks.Continuous.PID"},
{"initType"}, {"initType=if Integer(%initType%) < 5 then %initType% else Modelica.Blocks.Types.Init.NoInit"}, true);

The problem with the above is that it uses the non-existent enumeration element. IF the value is literal I assume it would be possible to find some solution, but if initType is non-literal (e.g. a propagated parameter) I don't see how it could be done in one go with current conversions.

I see the following possibility

Just convert the enumeration element - not the modifier! I tried the following alternatives:

convertClass("Modelica.Blocks.Types.InitPID.DoNotUse_InitialIntegratorState",
"Modelica.Blocks.Types.Init.NoInit");

convertElement("Modelica.Blocks.Types.InitPID","DoNotUse_InitialIntegratorState",
              "NoInit");

And even if the second may seem more correct (even if neither is really good), the first worked better in Dymola; and I can understand that it is similar for other tools.

I didn't fully understand if that handled the conversion completely or not. If it doesn't something more advanced is needed.

[HansOlsson]

Added comments in conversation. The completed part seems good.

[beutlich]

This PR is now ready for review.

And even if the second may seem more correct (even if neither is really good), the first worked better in Dymola; and I can understand that it is similar for other tools.

I didn't fully understand if that handled the conversion completely or not. If it doesn't something more advanced is needed.

It required all three commands

convertClass("Modelica.Blocks.Types.Init.DoNotUse_InitialIntegratorState",
              "Modelica.Blocks.Types.Init.NoInit");
convertClass("Modelica.Blocks.Types.InitPID.DoNotUse_InitialIntegratorState",
              "Modelica.Blocks.Types.Init.NoInit");
convertClass("Modelica.Blocks.Types.InitPID",
              "Modelica.Blocks.Types.Init");

to successfully run the conversion of ModelicaTestConversion4.Blocks.Issue2892 in Dymola 2020.

[HansOlsson]

Looks good.