Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix component name from variableResistor to variableConductor to match class name #2910

Merged
merged 1 commit into from
May 13, 2019
Merged

Fix component name from variableResistor to variableConductor to match class name #2910

merged 1 commit into from
May 13, 2019

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented May 2, 2019

Fix #2693.

@beutlich beutlich added the L: Electrical.MultiPhase Issue addresses Modelica.Electrical.MultiPhase label May 2, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone May 2, 2019
@beutlich beutlich self-assigned this May 2, 2019
christiankral
christiankral approved these changes May 5, 2019
View reviewed changes
Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@beutlich beutlich added L: Electrical.QuasiStationary Issue addresses Modelica.Electrical.QuasiStationary and removed L: Electrical.MultiPhase Issue addresses Modelica.Electrical.MultiPhase labels May 5, 2019
@beutlich beutlich requested a review from dietmarw May 5, 2019 15:28
@beutlich
refs modelica#2693: Fix component name
14a0306 
Fix component name from variableResistor to variableConductor to match class name.
@beutlich beutlich force-pushed the issue2693-fix-component-name branch from 040c499 to 14a0306 Compare May 8, 2019 18:20
@beutlich beutlich removed the request for review from AHaumer May 13, 2019 14:25
@beutlich beutlich merged commit 3d22499 into modelica:master May 13, 2019
@beutlich beutlich deleted the issue2693-fix-component-name branch May 13, 2019 14:26
@beutlich beutlich added L: Electrical.QuasiStatic Issue addresses Modelica.Electrical.QuasiStatic and removed L: Electrical.QuasiStationary Issue addresses Modelica.Electrical.QuasiStationary labels Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dietmarw dietmarw dietmarw approved these changes

@christiankral christiankral christiankral approved these changes

Assignees

@beutlich beutlich

Labels
L: Electrical.QuasiStatic Issue addresses Modelica.Electrical.QuasiStatic
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

Rename instance variableResistor to variableConductor
3 participants
@beutlich @dietmarw @christiankral