Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix description and units in derivative functions IdealGases.Common.Functions.{cp_Tlow_der, h_T_der, h_Tlow_der} #2920

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Fix description and units in derivative functions IdealGases.Common.Functions.{cp_Tlow_der, h_T_der, h_Tlow_der} #2920

merged 2 commits into from
Jul 15, 2019

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented May 7, 2019

s0_Tlow_der is separately considered by #2919.

@beutlich beutlich added the L: Media Issue addresses Modelica.Media label May 7, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone May 7, 2019
@beutlich beutlich self-assigned this May 7, 2019
@beutlich beutlich changed the title Fix description and units in derivative functions Modelica.Media.IdealGases.Common.Functions.{cp_Tlow_der, h_T_der, h_Tlow_der} Fix description and units in derivative functions Media.IdealGases.Common.Functions.{cp_Tlow_der, h_T_der, h_Tlow_der} May 7, 2019
@beutlich beutlich changed the title Fix description and units in derivative functions Media.IdealGases.Common.Functions.{cp_Tlow_der, h_T_der, h_Tlow_der} Fix description and units in derivative functions IdealGases.Common.Functions.{cp_Tlow_der, h_T_der, h_Tlow_der} May 7, 2019
@beutlich beutlich requested a review from wischhusen May 14, 2019 18:27
casella
casella previously requested changes May 17, 2019
View reviewed changes
Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, except for the issue at line 98

@beutlich
Copy link
Member Author

Sounds good, except for the issue at line 98

Right. Resolved.

@beutlich beutlich requested a review from casella May 20, 2019 05:36
@beutlich
Copy link
Member Author

@casella Please update your review.
@hubertus65 @wischhusen Please add your review.

@beutlich
Copy link
Member Author

beutlich commented Jul 6, 2019

@casella Please update your review.
@hubertus65 @wischhusen Please add your review.

Please do not forget to add or update your review!

wischhusen
wischhusen approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@wischhusen wischhusen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@beutlich beutlich merged commit 4d42c91 into modelica:master Jul 15, 2019
@beutlich beutlich deleted the fix-der-functions branch July 15, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorade thorade thorade approved these changes

@wischhusen wischhusen wischhusen approved these changes

@casella casella casella left review comments

Assignees

@beutlich beutlich

Labels
L: Media Issue addresses Modelica.Media
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@beutlich @thorade @wischhusen @casella