Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements of PowerConverters (incl. fix for Signal2mPulse and new Voltage2DutyCycle) #2970

Merged
merged 34 commits into from
Jul 7, 2019
Merged

Enhancements of PowerConverters (incl. fix for Signal2mPulse and new Voltage2DutyCycle) #2970

merged 34 commits into from
Jul 7, 2019
+1,377 −190

Conversation

AHaumer
Copy link
Contributor

@AHaumer AHaumer commented Jun 13, 2019 •
edited by beutlich

Replaces PR #2955, summarizing the following enhancements:

  • Implements bugfix for Signal2mPulse (PR PowerConverters...Signal2mPulse #2965 for master and PowerConverters...Signal2mPulse #2967 for 3.2.3)
  • Enhanced Voltage2DutyCycle
  • VoltageToDutyCycle kept for compatibility, marked as obsolete and moved to ObsoleteModelica4
  • Adapts Machines.Examples.ControlledDCDrives.Utilities.SwitchingDcDc (new Voltage2DutyCycle)
  • Enhanced Examples.DCDC.{ChopperStepUp, ChopperStepDown}:
    • add inductor and smoothing capacitor
    • change default parameterization (more realistic and comparable)
    • StepDown results in 60 V -> 12 V / 1.2 A, StepUp results in 60 V -> 75 V / 1.2 A
  • Implement ACAC.Triac
  • Implement ACAC.Control.{VoltageToAngle, SoftStartControl}
  • Implement Examples.ACAC.SoftStarter

@AHaumer AHaumer added enhancement New feature or enhancement L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters P: high High priority issue labels Jun 13, 2019
@AHaumer AHaumer added this to the MSL4.0.0 milestone Jun 13, 2019
@AHaumer AHaumer changed the title Emhamcements of PowerConverters Emhancements of PowerConverters Jun 13, 2019
beutlich
beutlich reviewed Jun 13, 2019
View reviewed changes
Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it also replace #2965 then? 😕

@AHaumer AHaumer changed the title Emhancements of PowerConverters Enhancements of PowerConverters Jun 13, 2019
@AHaumer
Copy link
Contributor Author

AHaumer commented Jun 13, 2019 •
edited

yes, but not #2967
I needed the bugfix to test the enhacements.

@dietmarw
Copy link
Member

I suggest to wait with this enhancement for the benefit of the renaming of electrical machines and multiphase --> polyphase. This will save you some conversion work later on.

@christiankral christiankral mentioned this pull request Jun 17, 2019
Closed
@christiankral
Copy link
Contributor

I didn't want to re-request a review -- it happened accidentally.

@beutlich beutlich removed their request for review June 17, 2019 16:09
christiankral
christiankral approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some updates. OK.

dietmarw
dietmarw reviewed Jun 18, 2019
View reviewed changes
Modelica/Electrical/PowerConverters.mo
<ul>
<li>SinglePhase dimmer with <a href=\"modelica://Modelica.Electrical.PowerConverters.ACAC.SinglePhaseTriac\">triac</a></li>
<li>MultiPhase indcution machine soft starter with <a href=\"modelica://Modelica.Electrical.PowerConverters.ACAC.MultiPhaseTriac\">triac</a></li>
</ul>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos and the use of Multiphase should be fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to make a search for multi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still typo in "indcution machine"

@christiankral
Copy link
Contributor

OK, changed MutliPhase to Polyphase and SinglePhase to Single-phase. These changes apply to the newly introduced components only. Existing mutli and single phase names and components will be changed in a different ticket and PR.

@christiankral
Copy link
Contributor

The correct spellings are single-phase and polyphase. From this lingual spelling I derive the Modelica spelling SinglePhase and Polyphase. Correct?

@dietmarw
Copy link
Member

Yes. In order to have some kind of persistent linkage between the camel case and the original spelling that is how I would write it. You should go over the changes one more time and keep an eye out for this.

beutlich
beutlich requested changes Jun 20, 2019
View reviewed changes
Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modelica.Electrical.PowerConverters.DCDC.Control.VoltageToDutyCycle misses the obsolete annotation;

obsolete = "Obsolete block - use Modelica.Electrical.PowerConverters.DCDC.Control.Voltage2DutyCycle instead");

@beutlich beutlich changed the title Enhancements of PowerConverters Enhancements of PowerConverters (incl. fix for Signal2mPulse and new Voltage2DutyCycle) Jun 20, 2019
christiankral and others added 19 commits July 7, 2019 17:06
@christiankral @beutlich
Change color blue of SoftStartControl
3595848 
Change blue to rgb(0,0,255)
@christiankral @beutlich
Center text in PowerConverters.DCAC.Control.PWM
a100ac8
@christiankral @beutlich
Parameter Vnom -> VNominal
9737f30 
Remove Dymola specific annotation
@christiankral @beutlich
Change Inom -> INominal
e630ee5
@christiankral @beutlich
Change vLimExt to vLim and vLim to VLim
faa9cf8 
This better matches the structure of the PowerConverters package
@christiankral @beutlich
Rename output "alpha" to "firingAngle"
d9fbf96 
For consistency reasons of the PowerConverters library
@christiankral @beutlich
Unify wording of parameters and types
57443e6
@christiankral @beutlich
Set min and max attributes to final
f432de7 
Add final attributes of the Triac models
@christiankral @beutlich
Change MultiPhase to Polyphase and singlephase to singe-phase
d223ddb
@christiankral @beutlich
Fix Indcution -> Induction
02beb48
@AHaumer @beutlich
corrected spelling
4f2a3c6
@christiankral @beutlich
Add obsolete message
ebf83fb
@christiankral @beutlich
Fix: Remove "Block" from class name in documentation
ecb68f4 
Suggested by modelica#2970 (comment)
@christiankral @beutlich
Move VoltageToDutyCycle to ObsoleteModelica4
d966171
@christiankral @beutlich
Add unit "V" for both inputs
d0caecf
@christiankral @beutlich
Update information on PowerConverters
97ccfab
@christiankral @beutlich
Add test model for issue modelica#2970
1e69ad3
@christiankral @beutlich
Test conversion of Signal2mPulse.negativeEqual
4b16d8f 
Currently not working as   
toBeConverted = signal2mPulse.negativeEqual[1].y;
is not converted in Issue2970
@beutlich
Fix typo
c7c3726
@beutlich beutlich merged commit 7855ea3 into modelica:master Jul 7, 2019
@AHaumer AHaumer deleted the PowerConverters branch July 13, 2019 19:44
@beutlich beutlich mentioned this pull request Jul 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dietmarw dietmarw dietmarw left review comments

@christiankral christiankral christiankral approved these changes

@beutlich beutlich beutlich approved these changes

Assignees

@christiankral christiankral

@AHaumer AHaumer

Labels
enhancement New feature or enhancement L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters P: high High priority issue
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AHaumer @dietmarw @christiankral @beutlich