Convert "HeatingResistor" to "Resistor" in Electrical.Analog

[christiankral]

see #2899

[beutlich]

Do you want me to exclude the "invalid" commit on V.A?

[christiankral]

The conversion script proposed in #2899 (comment) does not work in Dymola. I therefore changed it in c31d6a8 -- which triggers Dymola to convert Issue2899 as intended.

However, I do not understand why the performed change in c31d6a8 works, as this makes only sense to me if

convertElement("Modelica.Electrical.Analog.Basic.HeatingResistor",
               {"R_ref"},
               {"R"});

is performed before

convertClass("Modelica.Electrical.Analog.Basic.HeatingResistor",
              "Modelica.Electrical.Analog.Basic.Resistor");

even though the two conversions are implemented in the conversion script in the opposite order.

@beutlich Can you please double check if the conversion script is correct?

[beutlich]

@christiankral Can only check in Dymola, too, which is the only kown tool to support conversion currently.

We could also rename R to R_ref in Resistor.

[beutlich]

Conversion of ModelicaTestConversion4.Electrical.Analog.Issue2899 works as expected.

[beutlich]

Please update Modelica.Electrical.Analog.Examples.HeatingResistor to no longer use the HeatingResistor.

[christiankral]

Do you want me to exclude the "invalid" commit on V.A?

@beutlich My fault. I guess I shall "undo" the change, as the change is handled in #2982, correct

[beutlich]

Yes, you can do so.

[christiankral]

Please update Modelica.Electrical.Analog.Examples.HeatingResistor to no longer use the HeatingResistor.

Thanks, first I thought about it then then I forgot about it... I will change the example.

[HansOlsson]

The conversion script proposed in #2899 (comment) does not work in Dymola. I therefore changed it
...
is performed before

The script-commands don't convert models one by one, but they sort of create a conversion table that is then applied in one go - and that's why the order doesn't matter.