Remove ObsoleteModelica3 and conversion to MSL v3.x.y #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beutlich
added
task
dietmarw
approved these changes
Jun 21, 2019
HansOlsson
approved these changes
Jun 24, 2019
There was a problem hiding this comment.
The change looks consistent with the description.
My minor concern is that it wasn't certain that it was needed, and we could have modified the line below as follows instead of deleting it:
from(version={"2.1", "2.2", "2.2.1", "2.2.2"}, to="3.2.3", script="modelica://Modelica/Resources/Scripts/Conversion/Dymola/ConvertModelica_from_2.2.2_to_3.0.mos"),
However, MSL 2.2.2 was released almost 12 years ago, and Dymola no longer supports it (except for converting to MSL 3), and MSL 3.0.0 is more than 11 years old, and when MSL 4.0.0 releases MSL 3.0.0 is likely to be 12 years as well, so I really hope that customers have already converted to MSL 3, and thus it should be ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1578.