Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid code duplication in Modelica.Fluid.Pipes.BaseClasses.WallFriction.Detailed #3001

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Avoid code duplication in Modelica.Fluid.Pipes.BaseClasses.WallFriction.Detailed #3001

merged 1 commit into from
Aug 1, 2019

Conversation

beutlich
Copy link
Member

See #2972.

@beutlich beutlich added the L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) label Jun 23, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Jun 23, 2019
@beutlich beutlich self-assigned this Jun 23, 2019
@beutlich
Copy link
Member Author

@wischhusen @thorade What do you think?

@thorade
Copy link
Contributor

thorade commented Jul 23, 2019 •
edited

For my understanding: Would that other function be identical or would it already have fixes for issue #2972?
Both ways, it is good to remove the duplication and have just one correct version.

@beutlich
Copy link
Member Author

This PR actually is independent of #2972.

@beutlich beutlich requested a review from dietmarw August 1, 2019 14:08
@beutlich beutlich merged commit f10e962 into modelica:master Aug 1, 2019
@beutlich beutlich deleted the avoid-duplicated-code branch August 1, 2019 20:20
@beutlich beutlich added the task General work that is not related to a bug or feature label Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dietmarw dietmarw dietmarw approved these changes

@thorade thorade thorade approved these changes

Assignees

@beutlich beutlich

Labels
L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) task General work that is not related to a bug or feature
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@beutlich @thorade @dietmarw