Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer Text.textColor attribute (and do no longer use deprecated Text.lineColor) #3014

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Prefer Text.textColor attribute (and do no longer use deprecated Text.lineColor) #3014

merged 1 commit into from
Jul 1, 2019

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Jun 29, 2019 •
edited

Here's how I did it in Notepad++

  • Find what: (Text\s*\([^\).]*)lineColor
  • Replace with: (\1)textColor

grafik

Closes #2152.

@beutlich beutlich added the task General work that is not related to a bug or feature label Jun 29, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Jun 29, 2019
@beutlich beutlich self-assigned this Jun 29, 2019
HansOlsson
HansOlsson approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
(BTW in Dymola you don't have to use notepad for this, but can do: updateModelicaAnnotations("Modelica", changeLinePattern=false, orderBitmapExtent=false, removeTextDeprecated=true, renameTextColor=true); and similarly )

@beutlich beutlich merged commit cf6aeec into modelica:master Jul 1, 2019
@beutlich beutlich deleted the replace-lineColor-in-text branch July 1, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dietmarw dietmarw dietmarw approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@beutlich beutlich

Labels
task General work that is not related to a bug or feature
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

Remove deprecated Text.lineColor attribute in graphical annotations
3 participants
@beutlich @dietmarw @HansOlsson