Remove all obsolete classes from Modelica.Electrical.Spice3.Internal #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beutlich
added
L: Electrical.Spice3
beutlich
force-pushed
the
clean-up-spice3
branch
from
1e621b2
to
d86da41
Compare
|
@christophclauss @JoeRiel Please review. |
JoeRiel
approved these changes
Jul 17, 2019
beutlich
added a commit
to beutlich/ModelicaStandardLibrary
that referenced
this pull request
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is neither conversion provided nor possible. Instead, a conversion message is raised, if internal classes of Spice3 are to be converted.
There is one backward-compatibility breaking change in Modelica.Electrical.Spice3.Internal.MOS2, since the final parameter vp was declared as return value of the (obsolete and now removed) function Modelica.Electrical.Spice3.Internal.Mos2.mos2ModelLineParamsInitEquations, but mos2ModelLineParamsInitEquationsRevised has a different return type. In the current PR I simply decided to remove that parameter since it was not used (think so) and set final anyway, thus could not be modified in derived classes.
Closes #608, closes #784.