Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Modelica.Electrical.Analog.Basic.OpAmpDetailed.Pi #3024

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Remove Modelica.Electrical.Analog.Basic.OpAmpDetailed.Pi #3024

merged 1 commit into from
Jul 15, 2019

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Jul 5, 2019

No description provided.

@beutlich beutlich added the L: Electrical.Analog Issue addresses Modelica.Electrical.Analog label Jul 5, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Jul 5, 2019
@beutlich beutlich self-assigned this Jul 5, 2019
@beutlich beutlich added the task General work that is not related to a bug or feature label Jul 6, 2019
@beutlich beutlich requested review from AHaumer and removed request for AHaumer July 6, 2019 17:08
@AHaumer
Copy link
Contributor

AHaumer commented Jul 13, 2019

Would like to see a comment from @christophclauss and / or @kristinmajetta

christophclauss
christophclauss approved these changes Jul 15, 2019
View reviewed changes
Copy link

@christophclauss christophclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fine to me. We left this definition of Pi in the model, since it is possible that a user applies Pi from this model. This is improbable, the user shall use Modelica.Constants.pi.

@beutlich beutlich merged commit 7a6a457 into modelica:master Jul 15, 2019
@beutlich beutlich deleted the remove-Pi branch July 15, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christiankral christiankral christiankral approved these changes

@christophclauss christophclauss christophclauss approved these changes

Assignees

@beutlich beutlich

Labels
L: Electrical.Analog Issue addresses Modelica.Electrical.Analog task General work that is not related to a bug or feature
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@beutlich @AHaumer @christiankral @christophclauss