New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change table to figure tag in User's Guide #3033
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This highlights one part that was only part of the old examples - but not stated: the placement of the caption.
Old caption in tables used align="bottom" to indicate that they should be placed beneath the image. That is also part of the examples. However, it is not documented and for figures that instead depend on the order between img and figcaption. I believe that should be made clear if that is the intent; especially since the caption was normally placed before the table-data (and thus has to be moved).
I also noticed that Dymola's internal rendering does not seem to fully support the new variant; which causes a bit of problem for us.
Your are right! |
This is fixed in f6f93c1.
As the release of the MSL 4.0.0 is due in March 2020, I guess there is sufficient time to fix this display issue in Dymola. @HansOlsson is this a proper approach? |
Here's my proposal of the release schedule:
|
@HansOlsson Do you think we shall proceed with this PR? |
I'd prefer to wait with merging this PR after modelica/ModelicaSpecification#2395 is resolved. Thus, it only can be merged after MSL v4.0.0 (which will be based on Modelica v3.4) Similarily, we have no SVGs in the MSL, but need to wait for modelica/ModelicaSpecification#174. |
OK. I understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suspending this PR just to avoid accidental merging.
Refs #2519