Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change table to figure tag in User's Guide #3033

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

christiankral
Copy link
Contributor

Refs #2519

@christiankral christiankral added the L: UsersGuide Issue addresses Modelica.UsersGuide label Jul 11, 2019
@christiankral christiankral added this to the MSL4.0.0 milestone Jul 11, 2019
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This highlights one part that was only part of the old examples - but not stated: the placement of the caption.

Old caption in tables used align="bottom" to indicate that they should be placed beneath the image. That is also part of the examples. However, it is not documented and for figures that instead depend on the order between img and figcaption. I believe that should be made clear if that is the intent; especially since the caption was normally placed before the table-data (and thus has to be moved).

I also noticed that Dymola's internal rendering does not seem to fully support the new variant; which causes a bit of problem for us.

@tobolar
Copy link
Contributor

tobolar commented Jul 12, 2019

@HansOlsson

Dymola's internal rendering does not seem to fully support the new variant...

Your are right!

grafik

@christiankral
Copy link
Contributor Author

This highlights one part that was only part of the old examples - but not stated: the placement of the caption.

Old caption in tables used align="bottom" to indicate that they should be placed beneath the image. That is also part of the examples. However, it is not documented and for figures that instead depend on the order between img and figcaption. I believe that should be made clear if that is the intent; especially since the caption was normally placed before the table-data (and thus has to be moved).

This is fixed in f6f93c1.

I also noticed that Dymola's internal rendering does not seem to fully support the new variant; which causes a bit of problem for us.

As the release of the MSL 4.0.0 is due in March 2020, I guess there is sufficient time to fix this display issue in Dymola. @HansOlsson is this a proper approach?

@beutlich
Copy link
Member

As the release of the MSL 4.0.0 is due in March 2020

Here's my proposal of the release schedule:

  • January 2020 MSL v4.0.0 Alpha
  • February 2020 MSL v4.0.0 Beta
  • Early March 2020 MSL v4.0.0 RC.1
  • 2020-03-25 MSL v4.0.0 Release

@beutlich beutlich changed the title Change <table> to <figure> in User's Guide Change table to figure tag in User's Guide Jul 27, 2019
@dietmarw dietmarw removed their request for review August 12, 2019 07:20
@christiankral
Copy link
Contributor Author

@HansOlsson Do you think we shall proceed with this PR?

@beutlich
Copy link
Member

I'd prefer to wait with merging this PR after modelica/ModelicaSpecification#2395 is resolved. Thus, it only can be merged after MSL v4.0.0 (which will be based on Modelica v3.4)

Similarily, we have no SVGs in the MSL, but need to wait for modelica/ModelicaSpecification#174.

@beutlich beutlich removed this from the MSL4.0.0 milestone Oct 19, 2019
@christiankral
Copy link
Contributor Author

OK. I understand.

Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suspending this PR just to avoid accidental merging.

@beutlich beutlich changed the title Change table to figure tag in User's Guide [Do not merge yet] Change table to figure tag in User's Guide Feb 23, 2020
@beutlich beutlich changed the title [Do not merge yet] Change table to figure tag in User's Guide Change table to figure tag in User's Guide Feb 28, 2020
@beutlich beutlich removed their assignment May 4, 2020
@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: UsersGuide Issue addresses Modelica.UsersGuide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants