Implement SinCosResolver #3059
Merged
Implement SinCosResolver #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AHaumer
added
enhancement
…ties.SinCosEvaluation in a backwards compatible way
christiankral
approved these changes
Jul 17, 2019
beutlich
approved these changes
Jul 18, 2019
AHaumer
added a commit
to AHaumer/ModelicaStandardLibrary
that referenced
this pull request
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be a great advantage to have a sin-cos-resolver model and the block that evaluates the signals at hand. When creating FMUs for developing control in a different environment, later switching to HIL, the FMU has to provide the same signals as the HIL interface. Small effort, but big advantage.
Of course I have to take care of the changes introduced by #3058 before merging.