-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Thermal.{FluidHeatFlow, HeatTransfer} into single files #3061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I am not a supporter of these changes.
@beutlich what's the reason? |
|
Same holds for Search+Replace. If I want to check if the "Ah" issue is resolved in the other PR, I previously only needed to search in Batteries.mo. Now I need to check 36 files (excluding the package.order files) to see which file it actually was in. Thus in Notepad++ I can no longer do a single file search but need to do a directory search (where search hits are given as list). For me it simply is less convenient. |
So it is more a matter of tools. Dymola itself got quite efficient with renaming and search for usage by other components. Nevertheless, I would prefer files since changes for one model do not affect a whole sub-library. @AHaumer : I think this is a very general problem and should be agreed among the library officers. |
@DrMartinKuhn The library officers of both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case I approve the change and invite Thomas to have a beer discussion on tool issues
To be exact: At least two positive approvals and no negative review. |
Hm I've no idea how to resolve the conflicts. Seems to be the old "all-in-one" files that should be deleted, merging the directorires (with single files). Who could help me, please? |
Done. |
@beurlich thanks a lot - just to learn: how did you do that? |
Since for Thermal there are no open PRs at this time, I'd want to grab the opportunity and split the sublibraries into single files