Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add second derivatives to table blocks #3083

Merged
merged 2 commits into from
Oct 20, 2019
Merged

Add second derivatives to table blocks #3083

merged 2 commits into from
Oct 20, 2019

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Aug 9, 2019

Close #2901.

@beutlich beutlich added enhancement New feature or enhancement L: Blocks Issue addresses Modelica.Blocks labels Aug 9, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Aug 9, 2019
@beutlich beutlich self-assigned this Aug 9, 2019
@beutlich beutlich mentioned this pull request Aug 9, 2019
Closed
@beutlich beutlich added the L: C-Sources Issue addresses Modelica/Resources/C-Sources label Aug 9, 2019
@beutlich beutlich requested a review from thorade August 9, 2019 11:34
thorade
thorade reviewed Aug 9, 2019
View reviewed changes
Copy link
Contributor

@thorade thorade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add a test?

@beutlich
Copy link
Member Author

beutlich commented Aug 9, 2019 •
edited

Would it be possible to add a test?

I used #2901 (comment) as a test for CombiTimeTable after replacing the approximated second derivative by the symbolic second derivative.

HansOlsson
HansOlsson approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@beutlich beutlich changed the title Add second derivatives Add second derivatives to table blocks Aug 22, 2019
@beutlich
Copy link
Member Author

Would it be possible to add a test?

8af9758 updates all test models.

@beutlich beutlich merged commit 9c20203 into modelica:master Oct 20, 2019
@beutlich beutlich deleted the add-2nd-derivatives branch October 20, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorade thorade thorade approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@beutlich beutlich

Labels
enhancement New feature or enhancement L: Blocks Issue addresses Modelica.Blocks L: C-Sources Issue addresses Modelica/Resources/C-Sources
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

Provide higher order derivatives for CombiTables
3 participants
@beutlich @thorade @HansOlsson